You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/04/15 21:51:11 UTC

[GitHub] [geode] gesterzhou commented on a diff in pull request #7594: GEODE-10023: Fix javadocs

gesterzhou commented on code in PR #7594:
URL: https://github.com/apache/geode/pull/7594#discussion_r851528925


##########
geode-assembly/geode-assembly-test/src/main/java/org/apache/geode/session/tests/ContainerInstall.java:
##########
@@ -248,32 +252,36 @@ int getDefaultLocatorPort() {
     return defaultLocatorPort;
   }
 
-  /**
+  /*
    * Gets the cache XML file to use by default for this installation
    */
   File getCacheXMLFile() {
     return new File(modulePath + "/conf/" + getConnectionType().getCacheXMLFileName());
   }
 
-  /**
+  /*
    * Cargo specific string to identify the container with
    */
   public abstract String getInstallId();
 
-  /**
+  /*
    * A human readable description of the installation
    */
   public abstract String getInstallDescription();
 
-  /**
+  /*
    * Get the session manager class to use
    */
   public abstract String getContextSessionManagerClass();
 
   /**
    * Generates a {@link ServerContainer} from the given {@link ContainerInstall}
    *
+   * @param containerConfigHome The folder that the container configuration folder should be setup

Review Comment:
   these 2 lines can be adjusted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org