You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/11/14 23:12:30 UTC
Review Request 63818: Added quick start instructions for CMake.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63818/
-----------------------------------------------------------
Review request for mesos, Gaston Kleiman and Greg Mann.
Repository: mesos
Description
-------
Added quick start instructions for CMake.
Diffs
-----
docs/cmake.md b8f9e7caa84372404256767a0220ac1df9db8bc8
Diff: https://reviews.apache.org/r/63818/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 63818: Added quick start instructions for CMake.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63818/#review191038
-----------------------------------------------------------
PASS: Mesos patch 63818 was successfully built and tested.
Reviews applied: `['63818']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63818
- Mesos Reviewbot Windows
On Nov. 14, 2017, 3:12 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63818/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2017, 3:12 p.m.)
>
>
> Review request for mesos, Gaston Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added quick start instructions for CMake.
>
>
> Diffs
> -----
>
> docs/cmake.md b8f9e7caa84372404256767a0220ac1df9db8bc8
>
>
> Diff: https://reviews.apache.org/r/63818/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 63818: Added quick start instructions for CMake.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63818/#review191080
-----------------------------------------------------------
Ship it!
Thanks for the doc update!!!
docs/cmake.md
Lines 50 (patched)
<https://reviews.apache.org/r/63818/#comment268675>
s/is/produces/
I can fix this when committing.
- Greg Mann
On Nov. 14, 2017, 11:12 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63818/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2017, 11:12 p.m.)
>
>
> Review request for mesos, Gaston Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added quick start instructions for CMake.
>
>
> Diffs
> -----
>
> docs/cmake.md b8f9e7caa84372404256767a0220ac1df9db8bc8
>
>
> Diff: https://reviews.apache.org/r/63818/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 63818: Added quick start instructions for CMake.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Nov. 14, 2017, 5:40 p.m., Gaston Kleiman wrote:
> > docs/cmake.md
> > Lines 43 (patched)
> > <https://reviews.apache.org/r/63818/diff/1/?file=1892196#file1892196line43>
> >
> > I had to look up how to pass more parameters to make in order to use more threads:
> >
> > `cmake --build . -- -j 4`
> >
> > It might be useful to mention that here =).
Oh yeah, that's a good point. I usually run `-- /m` on Windows. I'll add it.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63818/#review191023
-----------------------------------------------------------
On Nov. 14, 2017, 3:12 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63818/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2017, 3:12 p.m.)
>
>
> Review request for mesos, Gaston Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added quick start instructions for CMake.
>
>
> Diffs
> -----
>
> docs/cmake.md b8f9e7caa84372404256767a0220ac1df9db8bc8
>
>
> Diff: https://reviews.apache.org/r/63818/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 63818: Added quick start instructions for CMake.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63818/#review191023
-----------------------------------------------------------
Ship it!
This is super helpful, thanks!
docs/cmake.md
Lines 43 (patched)
<https://reviews.apache.org/r/63818/#comment268617>
I had to look up how to pass more parameters to make in order to use more threads:
`cmake --build . -- -j 4`
It might be useful to mention that here =).
- Gaston Kleiman
On Nov. 14, 2017, 3:12 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63818/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2017, 3:12 p.m.)
>
>
> Review request for mesos, Gaston Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added quick start instructions for CMake.
>
>
> Diffs
> -----
>
> docs/cmake.md b8f9e7caa84372404256767a0220ac1df9db8bc8
>
>
> Diff: https://reviews.apache.org/r/63818/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 63818: Added quick start instructions for CMake.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63818/
-----------------------------------------------------------
(Updated Nov. 15, 2017, 11:08 a.m.)
Review request for mesos, Gaston Kleiman and Greg Mann.
Changes
-------
Updated.
Repository: mesos
Description
-------
Added quick start instructions for CMake.
Diffs (updated)
-----
docs/cmake.md b8f9e7caa84372404256767a0220ac1df9db8bc8
Diff: https://reviews.apache.org/r/63818/diff/2/
Changes: https://reviews.apache.org/r/63818/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer