You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nikhil P <np...@gmail.com> on 2019/11/12 13:10:11 UTC
Review Request 71617: RANGER-2644 : Improvement in Ranger encryption
algorithm usage
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71617/
-----------------------------------------------------------
Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2644
https://issues.apache.org/jira/browse/RANGER-2644
Repository: ranger
Description
-------
Improvement in Ranger encryption algorithm usage
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 9e457826e
security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java 303705329
security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 8ebeeb555
Diff: https://reviews.apache.org/r/71617/diff/1/
Testing
-------
Tested If SHA256 algorithm is used for encryption.
Made sure ranger setup process runs properly and default password change request does not fail.
Thanks,
Nikhil P
Re: Review Request 71617: RANGER-2644 : Improvement in Ranger
encryption algorithm usage
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71617/#review218600
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Nov. 12, 2019, 1:10 p.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71617/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2019, 1:10 p.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2644
> https://issues.apache.org/jira/browse/RANGER-2644
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Improvement in Ranger encryption algorithm usage
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 9e457826e
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java 303705329
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 8ebeeb555
>
>
> Diff: https://reviews.apache.org/r/71617/diff/1/
>
>
> Testing
> -------
>
> Tested If SHA256 algorithm is used for encryption.
> Made sure ranger setup process runs properly and default password change request does not fail.
>
>
> Thanks,
>
> Nikhil P
>
>
Re: Review Request 71617: RANGER-2644 : Improvement in Ranger
encryption algorithm usage
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71617/#review218632
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Nov. 12, 2019, 1:10 p.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71617/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2019, 1:10 p.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2644
> https://issues.apache.org/jira/browse/RANGER-2644
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Improvement in Ranger encryption algorithm usage
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 9e457826e
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java 303705329
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 8ebeeb555
>
>
> Diff: https://reviews.apache.org/r/71617/diff/1/
>
>
> Testing
> -------
>
> Tested If SHA256 algorithm is used for encryption.
> Made sure ranger setup process runs properly and default password change request does not fail.
>
>
> Thanks,
>
> Nikhil P
>
>
Re: Review Request 71617: RANGER-2644 : Improvement in Ranger
encryption algorithm usage
Posted by Nikhil P <np...@gmail.com>.
> On Nov. 13, 2019, 1:29 a.m., Ramesh Mani wrote:
> > security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java
> > Lines 209 (patched)
> > <https://reviews.apache.org/r/71617/diff/1/?file=2172305#file2172305line209>
> >
> > md5EncryptedPassword => can this be null?
> > Do we need to check dbPassword.equals(md5EncryptedPassword) if that is the case?
encryptWithOlderAlgo will always return non null md5EncryptedPassword
- Nikhil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71617/#review218604
-----------------------------------------------------------
On Nov. 12, 2019, 6:40 p.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71617/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2019, 6:40 p.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2644
> https://issues.apache.org/jira/browse/RANGER-2644
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Improvement in Ranger encryption algorithm usage
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 9e457826e
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java 303705329
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 8ebeeb555
>
>
> Diff: https://reviews.apache.org/r/71617/diff/1/
>
>
> Testing
> -------
>
> Tested If SHA256 algorithm is used for encryption.
> Made sure ranger setup process runs properly and default password change request does not fail.
>
>
> Thanks,
>
> Nikhil P
>
>
Re: Review Request 71617: RANGER-2644 : Improvement in Ranger
encryption algorithm usage
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71617/#review218604
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java
Lines 209 (patched)
<https://reviews.apache.org/r/71617/#comment306391>
md5EncryptedPassword => can this be null?
Do we need to check dbPassword.equals(md5EncryptedPassword) if that is the case?
- Ramesh Mani
On Nov. 12, 2019, 1:10 p.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71617/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2019, 1:10 p.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2644
> https://issues.apache.org/jira/browse/RANGER-2644
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Improvement in Ranger encryption algorithm usage
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 9e457826e
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java 303705329
> security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 8ebeeb555
>
>
> Diff: https://reviews.apache.org/r/71617/diff/1/
>
>
> Testing
> -------
>
> Tested If SHA256 algorithm is used for encryption.
> Made sure ranger setup process runs properly and default password change request does not fail.
>
>
> Thanks,
>
> Nikhil P
>
>