You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2019/05/29 20:24:11 UTC
[kudu-CR] docs: update docs for heap sampling
Hello Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13459
to review the following change.
Change subject: docs: update docs for heap sampling
......................................................................
docs: update docs for heap sampling
Heap sampling is now enabled by default, but the docs were not updated
to reflect this. This patch updates the docs accordingly.
Change-Id: I5bdf8b2175f1bc492e98dc2a815bde4ab8fbe626
---
M docs/troubleshooting.adoc
1 file changed, 1 insertion(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/13459/1
--
To view, visit http://gerrit.cloudera.org:8080/13459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bdf8b2175f1bc492e98dc2a815bde4ab8fbe626
Gerrit-Change-Number: 13459
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] docs: update docs for heap sampling
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13459 )
Change subject: docs: update docs for heap sampling
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, docs change.
--
To view, visit http://gerrit.cloudera.org:8080/13459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdf8b2175f1bc492e98dc2a815bde4ab8fbe626
Gerrit-Change-Number: 13459
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Jun 2019 05:44:32 +0000
Gerrit-HasComments: No
[kudu-CR] docs: update docs for heap sampling
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13459 )
Change subject: docs: update docs for heap sampling
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13459/1/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:
http://gerrit.cloudera.org:8080/#/c/13459/1/docs/troubleshooting.adoc@a640
PS1, Line 640:
Should we add a doc on how to disable heap sampling?
--
To view, visit http://gerrit.cloudera.org:8080/13459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdf8b2175f1bc492e98dc2a815bde4ab8fbe626
Gerrit-Change-Number: 13459
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 31 May 2019 00:55:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] docs: update docs for heap sampling
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13459 )
Change subject: docs: update docs for heap sampling
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I5bdf8b2175f1bc492e98dc2a815bde4ab8fbe626
Gerrit-Change-Number: 13459
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] docs: update docs for heap sampling
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13459 )
Change subject: docs: update docs for heap sampling
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdf8b2175f1bc492e98dc2a815bde4ab8fbe626
Gerrit-Change-Number: 13459
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 17:25:01 +0000
Gerrit-HasComments: No
[kudu-CR] docs: update docs for heap sampling
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13459 )
Change subject: docs: update docs for heap sampling
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdf8b2175f1bc492e98dc2a815bde4ab8fbe626
Gerrit-Change-Number: 13459
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 17:24:38 +0000
Gerrit-HasComments: No
[kudu-CR] docs: update docs for heap sampling
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13459 )
Change subject: docs: update docs for heap sampling
......................................................................
docs: update docs for heap sampling
Heap sampling is now enabled by default, but the docs were not updated
to reflect this. This patch updates the docs accordingly.
Change-Id: I5bdf8b2175f1bc492e98dc2a815bde4ab8fbe626
Reviewed-on: http://gerrit.cloudera.org:8080/13459
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M docs/troubleshooting.adoc
1 file changed, 1 insertion(+), 6 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Will Berkeley: Looks good to me, approved
Adar Dembo: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5bdf8b2175f1bc492e98dc2a815bde4ab8fbe626
Gerrit-Change-Number: 13459
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] docs: update docs for heap sampling
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13459 )
Change subject: docs: update docs for heap sampling
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13459/1/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:
http://gerrit.cloudera.org:8080/#/c/13459/1/docs/troubleshooting.adoc@a640
PS1, Line 640:
> Should we add a doc on how to disable heap sampling?
I don't think so, unless we hear of some case where it caused problems for someone. Otherwise people might start thinking it's a thing that "needs tuning for production" and I don't want people to make false optimizations
--
To view, visit http://gerrit.cloudera.org:8080/13459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdf8b2175f1bc492e98dc2a815bde4ab8fbe626
Gerrit-Change-Number: 13459
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 17:23:52 +0000
Gerrit-HasComments: Yes