You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/03/31 09:38:08 UTC
Re: Review Request 58048: Added id to Resource.DiskInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/
-----------------------------------------------------------
(Updated March 31, 2017, 11:38 a.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Added some tests.
Bugs: MESOS-7312
https://issues.apache.org/jira/browse/MESOS-7312
Repository: mesos
Description
-------
Ids will allow to create distinguishable resources, e.g., of RAW or
BLOCK type.
Diffs (updated)
-----
include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c
src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
src/tests/mesos.hpp fe897c184829910addec95ace174546092a9e2b2
src/tests/resources_tests.cpp 343cab2af225a05e32c5a8bd4a5d9ddfbf76536d
src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
Diff: https://reviews.apache.org/r/58048/diff/2/
Changes: https://reviews.apache.org/r/58048/diff/1-2/
Testing
-------
make check (OS X, Fedora25)
Thanks,
Benjamin Bannier
Re: Review Request 58048: Added 'id' and 'metadata' fields to
'Resource.DiskInfo.Source'.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Sept. 2, 2017, 6:27 p.m., Jie Yu wrote:
> > This might need to be adjusted based on this:
> > https://github.com/container-storage-interface/spec/pull/97
> >
> > so `id` should be string, and `metadata` is labels given the above PR goes through
Like you suggested below, I moved `id` to `Source`, and also added a `metadata` field.
While `id` is considered when evaluating identity in the matrix you gave above, `metadata` just participates via equality.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review184432
-----------------------------------------------------------
On Sept. 12, 2017, 3:14 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2017, 3:14 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c
> include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5
> src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade
> src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc
> src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb
>
>
> Diff: https://reviews.apache.org/r/58048/diff/5/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added id to Resource.DiskInfo.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review184432
-----------------------------------------------------------
This might need to be adjusted based on this:
https://github.com/container-storage-interface/spec/pull/97
so `id` should be string, and `metadata` is labels given the above PR goes through
- Jie Yu
On May 19, 2017, 9:16 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 9:16 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154
> include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3
> src/common/resources.cpp 1d07f1a049ba3bb3f5d78f05031f33ba97e07e8c
> src/tests/mesos.hpp 3c57f25ff0bec55582b8a7decef53be61a9ec6f4
> src/tests/resources_tests.cpp 5dcbce2dd4944194b59790551929d6d75b805ba3
> src/v1/resources.cpp 1bb5d0741c9f9ea59f34e92159a335661019444d
>
>
> Diff: https://reviews.apache.org/r/58048/diff/4/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added 'id' and 'metadata' fields to
'Resource.DiskInfo.Source'.
Posted by Benjamin Bannier <bb...@apache.org>.
> On Sept. 18, 2017, 7:06 p.m., Jie Yu wrote:
> > src/tests/resources_tests.cpp
> > Lines 2251 (patched)
> > <https://reviews.apache.org/r/58048/diff/6/?file=1820868#file1820868line2251>
> >
> > s/ResourcesTest/DiskResourcesTest/
> >
> > In fact, this test a bit dense and has a bunch of if/elses, making it hard to read.
> >
> > Either split this into 3 tests (or 6 tests):
> > ```
> > DiskResourcesTest.RawSource
> > DiskResourcesTest.MountBlockSource
> > DiskResourcesTest.PathSource
> >
> > DiskResourcesTest.RawSourceWithID
> > DiskResourcesTest.MountBlockSourceWithID
> > DiskResourcesTest.PathSourceWithID
> > ```
> >
> > Or parameterize this test:
> > ```
> > DiskResourcesSourceTest
> > ```
> >
> > Given that expectation is different for each source type, i am leaning towards option 1 (3 tests or 6 tests). And you don't need to print the param anymore.
I went for a parameterized test as this allows to reuse most of the setup logic. The code still branches at two points, but I believe it should be better now that we do not manually loop over parameter permutations in the test case.
I also got rid of the parameter printing as it is clear from the running instantiation number.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review185569
-----------------------------------------------------------
On Sept. 19, 2017, 6:53 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2017, 6:53 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c
> include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5
> src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade
> src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc
> src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb
>
>
> Diff: https://reviews.apache.org/r/58048/diff/7/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added 'id' and 'metadata' fields to
'Resource.DiskInfo.Source'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review185569
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/resources_tests.cpp
Lines 2251 (patched)
<https://reviews.apache.org/r/58048/#comment261884>
s/ResourcesTest/DiskResourcesTest/
In fact, this test a bit dense and has a bunch of if/elses, making it hard to read.
Either split this into 3 tests (or 6 tests):
```
DiskResourcesTest.RawSource
DiskResourcesTest.MountBlockSource
DiskResourcesTest.PathSource
DiskResourcesTest.RawSourceWithID
DiskResourcesTest.MountBlockSourceWithID
DiskResourcesTest.PathSourceWithID
```
Or parameterize this test:
```
DiskResourcesSourceTest
```
Given that expectation is different for each source type, i am leaning towards option 1 (3 tests or 6 tests). And you don't need to print the param anymore.
- Jie Yu
On Sept. 13, 2017, 3:23 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2017, 3:23 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c
> include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5
> src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade
> src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc
> src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb
>
>
> Diff: https://reviews.apache.org/r/58048/diff/6/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added 'id' and 'metadata' fields to
'Resource.DiskInfo.Source'.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/
-----------------------------------------------------------
(Updated Sept. 19, 2017, 6:53 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Used parameterized test as suggested by Jie.
Bugs: MESOS-7312
https://issues.apache.org/jira/browse/MESOS-7312
Repository: mesos
Description
-------
Ids will allow to create distinguishable resources, e.g., of RAW or
BLOCK type. We also add a metadata field which can be used to expose
additional disk information.
Diffs (updated)
-----
include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c
include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5
src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade
src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc
src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb
Diff: https://reviews.apache.org/r/58048/diff/7/
Changes: https://reviews.apache.org/r/58048/diff/6-7/
Testing
-------
make check (OS X, Fedora25)
Thanks,
Benjamin Bannier
Re: Review Request 58048: Added 'id' and 'metadata' fields to
'Resource.DiskInfo.Source'.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/
-----------------------------------------------------------
(Updated Sept. 13, 2017, 5:23 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Bugs: MESOS-7312
https://issues.apache.org/jira/browse/MESOS-7312
Repository: mesos
Description
-------
Ids will allow to create distinguishable resources, e.g., of RAW or
BLOCK type. We also add a metadata field which can be used to expose
additional disk information.
Diffs (updated)
-----
include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c
include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5
src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade
src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc
src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb
Diff: https://reviews.apache.org/r/58048/diff/6/
Changes: https://reviews.apache.org/r/58048/diff/5-6/
Testing
-------
make check (OS X, Fedora25)
Thanks,
Benjamin Bannier
Re: Review Request 58048: Added 'id' and 'metadata' fields to
'Resource.DiskInfo.Source'.
Posted by Benjamin Bannier <bb...@apache.org>.
> On Sept. 13, 2017, 2:34 a.m., Jie Yu wrote:
> > src/common/resources.cpp
> > Lines 185 (patched)
> > <https://reviews.apache.org/r/58048/diff/5/?file=1820113#file1820113line185>
> >
> > hum, i think we also need to check? wondering if we need to fix the rest.
> > ```
> > if (left.has_id() != right.has_id()) {
> > return false;
> > }
> > ```
Yes, this was slightly broken. I pushed a fix in https://reviews.apache.org/r/62282/.
> On Sept. 13, 2017, 2:34 a.m., Jie Yu wrote:
> > src/common/resources.cpp
> > Lines 372 (patched)
> > <https://reviews.apache.org/r/58048/diff/5/?file=1820113#file1820113line374>
> >
> > I think we should treat BLOCK the same as MOUNT.
Yes, per our offline discussion this makes sense to me now.
> On Sept. 13, 2017, 2:34 a.m., Jie Yu wrote:
> > src/v1/resources.cpp
> > Lines 353-358 (original), 386-391 (patched)
> > <https://reviews.apache.org/r/58048/diff/5/?file=1820115#file1820115line386>
> >
> > Do you still need this?
Removed.
> On Sept. 13, 2017, 2:34 a.m., Jie Yu wrote:
> > src/v1/resources.cpp
> > Lines 491-493 (patched)
> > <https://reviews.apache.org/r/58048/diff/5/?file=1820115#file1820115line491>
> >
> > I think for RAW and if id are equal, we should return true (same as we did for MOUNT)
Yes, this was missing. I updated the test to confirm self-containment (`assert(r.contains(r))`). I also fixed the unintentional fall-through in the handling of `MOUNT` just above.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review185248
-----------------------------------------------------------
On Sept. 13, 2017, 5:23 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2017, 5:23 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c
> include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5
> src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade
> src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc
> src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb
>
>
> Diff: https://reviews.apache.org/r/58048/diff/6/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added 'id' and 'metadata' fields to
'Resource.DiskInfo.Source'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review185248
-----------------------------------------------------------
src/common/resources.cpp
Lines 185 (patched)
<https://reviews.apache.org/r/58048/#comment261549>
hum, i think we also need to check? wondering if we need to fix the rest.
```
if (left.has_id() != right.has_id()) {
return false;
}
```
src/common/resources.cpp
Lines 372 (patched)
<https://reviews.apache.org/r/58048/#comment261550>
I think we should treat BLOCK the same as MOUNT.
src/v1/resources.cpp
Lines 353-358 (original), 386-391 (patched)
<https://reviews.apache.org/r/58048/#comment261551>
Do you still need this?
src/v1/resources.cpp
Lines 487 (patched)
<https://reviews.apache.org/r/58048/#comment261552>
Ditto. Block should be treated the same as MOUNT
src/v1/resources.cpp
Lines 491-493 (patched)
<https://reviews.apache.org/r/58048/#comment261553>
I think for RAW and if id are equal, we should return true (same as we did for MOUNT)
- Jie Yu
On Sept. 12, 2017, 1:14 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2017, 1:14 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c
> include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5
> src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade
> src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc
> src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb
>
>
> Diff: https://reviews.apache.org/r/58048/diff/5/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added 'id' and 'metadata' fields to
'Resource.DiskInfo.Source'.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/
-----------------------------------------------------------
(Updated Sept. 12, 2017, 3:14 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Addressed a number of comments from Jie.
Summary (updated)
-----------------
Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.
Bugs: MESOS-7312
https://issues.apache.org/jira/browse/MESOS-7312
Repository: mesos
Description (updated)
-------
Ids will allow to create distinguishable resources, e.g., of RAW or
BLOCK type. We also add a metadata field which can be used to expose
additional disk information.
Diffs (updated)
-----
include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c
include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5
src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade
src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc
src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb
Diff: https://reviews.apache.org/r/58048/diff/5/
Changes: https://reviews.apache.org/r/58048/diff/4-5/
Testing
-------
make check (OS X, Fedora25)
Thanks,
Benjamin Bannier
Re: Review Request 58048: Added 'id' and 'metadata' fields to
'Resource.DiskInfo.Source'.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Aug. 28, 2017, 8:24 p.m., Jie Yu wrote:
> > src/common/resources.cpp
> > Line 187 (original), 187 (patched)
> > <https://reviews.apache.org/r/58048/diff/4/?file=1725749#file1725749line187>
> >
> > We also need to update `addable` and `subtractable` similar to what we did for persistent volumes.
> >
> > Depending on the "disk" source type, the semantics is different:
> > 1. RAW w/ id:
> > - Cannot be split into smaller pieces
> > - Cannot be merged even if they are equal
> > 2. RAW w/o id:
> > - Can be split into smaller pieces
> > - Can be merged if RAW parts equal
> > 3. PATH w/ id:
> > - Can be split into smaller pieces
> > - Can be merged if PATH parts equal
> > 4. PATH w/o id:
> > - Same as PATH w/ id
> > 5. MOUNT w/ id:
> > - Cannot be split into smaller pieces
> > - Cannot be merged even if they are equal
> > 6. MOUNT w/o id:
> > - Same as MOUNT w/ id
I updated the code to follow these semantics. You did not mention `BLOCK` sources above; I gave them the same semantics as `RAW` sources.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review183960
-----------------------------------------------------------
On Sept. 12, 2017, 3:14 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2017, 3:14 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c
> include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5
> src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade
> src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc
> src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb
>
>
> Diff: https://reviews.apache.org/r/58048/diff/5/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added id to Resource.DiskInfo.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review183960
-----------------------------------------------------------
src/common/resources.cpp
Line 187 (original), 187 (patched)
<https://reviews.apache.org/r/58048/#comment260003>
We also need to update `addable` and `subtractable` similar to what we did for persistent volumes.
Depending on the "disk" source type, the semantics is different:
1. RAW w/ id:
- Cannot be split into smaller pieces
- Cannot be merged even if they are equal
2. RAW w/o id:
- Can be split into smaller pieces
- Can be merged if RAW parts equal
3. PATH w/ id:
- Can be split into smaller pieces
- Can be merged if PATH parts equal
4. PATH w/o id:
- Same as PATH w/ id
5. MOUNT w/ id:
- Cannot be split into smaller pieces
- Cannot be merged even if they are equal
6. MOUNT w/o id:
- Same as MOUNT w/ id
- Jie Yu
On May 19, 2017, 9:16 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 9:16 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154
> include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3
> src/common/resources.cpp 1d07f1a049ba3bb3f5d78f05031f33ba97e07e8c
> src/tests/mesos.hpp 3c57f25ff0bec55582b8a7decef53be61a9ec6f4
> src/tests/resources_tests.cpp 5dcbce2dd4944194b59790551929d6d75b805ba3
> src/v1/resources.cpp 1bb5d0741c9f9ea59f34e92159a335661019444d
>
>
> Diff: https://reviews.apache.org/r/58048/diff/4/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added 'id' and 'metadata' fields to
'Resource.DiskInfo.Source'.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Sept. 6, 2017, 7:15 p.m., Jie Yu wrote:
> > include/mesos/mesos.proto
> > Lines 1044 (patched)
> > <https://reviews.apache.org/r/58048/diff/4/?file=1725747#file1725747line1044>
> >
> > Also, I'd suggest we put `id` into `source`. Given that the CSI spec change, we'll use string for `id` and `Labels` for metadata:
> >
> > ```
> > message Source {
> > optional string id;
> > optional Labels metadata;
> > }
> > ```
Done, see above.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review184703
-----------------------------------------------------------
On Sept. 12, 2017, 3:14 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2017, 3:14 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c
> include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5
> src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade
> src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc
> src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb
>
>
> Diff: https://reviews.apache.org/r/58048/diff/5/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added id to Resource.DiskInfo.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review184703
-----------------------------------------------------------
include/mesos/mesos.proto
Lines 1044 (patched)
<https://reviews.apache.org/r/58048/#comment260899>
Also, I'd suggest we put `id` into `source`. Given that the CSI spec change, we'll use string for `id` and `Labels` for metadata:
```
message Source {
optional string id;
optional Labels metadata;
}
```
- Jie Yu
On May 19, 2017, 9:16 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 9:16 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154
> include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3
> src/common/resources.cpp 1d07f1a049ba3bb3f5d78f05031f33ba97e07e8c
> src/tests/mesos.hpp 3c57f25ff0bec55582b8a7decef53be61a9ec6f4
> src/tests/resources_tests.cpp 5dcbce2dd4944194b59790551929d6d75b805ba3
> src/v1/resources.cpp 1bb5d0741c9f9ea59f34e92159a335661019444d
>
>
> Diff: https://reviews.apache.org/r/58048/diff/4/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added id to Resource.DiskInfo.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/
-----------------------------------------------------------
(Updated May 19, 2017, 11:16 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Addressed issue raised by Qian.
Bugs: MESOS-7312
https://issues.apache.org/jira/browse/MESOS-7312
Repository: mesos
Description
-------
Ids will allow to create distinguishable resources, e.g., of RAW or
BLOCK type.
Diffs (updated)
-----
include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154
include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3
src/common/resources.cpp 1d07f1a049ba3bb3f5d78f05031f33ba97e07e8c
src/tests/mesos.hpp 3c57f25ff0bec55582b8a7decef53be61a9ec6f4
src/tests/resources_tests.cpp 5dcbce2dd4944194b59790551929d6d75b805ba3
src/v1/resources.cpp 1bb5d0741c9f9ea59f34e92159a335661019444d
Diff: https://reviews.apache.org/r/58048/diff/4/
Changes: https://reviews.apache.org/r/58048/diff/3-4/
Testing
-------
make check (OS X, Fedora25)
Thanks,
Benjamin Bannier
Re: Review Request 58048: Added id to Resource.DiskInfo.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On May 17, 2017, 5:12 p.m., Qian Zhang wrote:
> > src/tests/resources_tests.cpp
> > Lines 2190 (patched)
> > <https://reviews.apache.org/r/58048/diff/3/?file=1685272#file1685272line2190>
> >
> > Unused variable?
Thanks, also fixed the other sites.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review175252
-----------------------------------------------------------
On May 19, 2017, 11:16 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 11:16 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154
> include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3
> src/common/resources.cpp 1d07f1a049ba3bb3f5d78f05031f33ba97e07e8c
> src/tests/mesos.hpp 3c57f25ff0bec55582b8a7decef53be61a9ec6f4
> src/tests/resources_tests.cpp 5dcbce2dd4944194b59790551929d6d75b805ba3
> src/v1/resources.cpp 1bb5d0741c9f9ea59f34e92159a335661019444d
>
>
> Diff: https://reviews.apache.org/r/58048/diff/4/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added id to Resource.DiskInfo.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review175252
-----------------------------------------------------------
src/tests/resources_tests.cpp
Lines 2190 (patched)
<https://reviews.apache.org/r/58048/#comment248705>
Unused variable?
- Qian Zhang
On April 5, 2017, 9:56 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated April 5, 2017, 9:56 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
> include/mesos/v1/mesos.proto 228623155c7f68c0f24d173aacbc6eb734f1382f
> src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
> src/tests/mesos.hpp fe897c184829910addec95ace174546092a9e2b2
> src/tests/resources_tests.cpp 343cab2af225a05e32c5a8bd4a5d9ddfbf76536d
> src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
>
>
> Diff: https://reviews.apache.org/r/58048/diff/3/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added id to Resource.DiskInfo.
Posted by Qian Zhang <zh...@gmail.com>.
> On April 17, 2017, 5:49 p.m., Jie Yu wrote:
> > src/tests/resources_tests.cpp
> > Lines 2255 (patched)
> > <https://reviews.apache.org/r/58048/diff/3/?file=1685272#file1685272line2255>
> >
> > instead of relying on 'count', let's use `size()` instead.
I think here the intention is to count how many `disks` are in `(r1 + r2)`, so `count()` should be the right method to call.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review172076
-----------------------------------------------------------
On April 5, 2017, 9:56 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated April 5, 2017, 9:56 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
> include/mesos/v1/mesos.proto 228623155c7f68c0f24d173aacbc6eb734f1382f
> src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
> src/tests/mesos.hpp fe897c184829910addec95ace174546092a9e2b2
> src/tests/resources_tests.cpp 343cab2af225a05e32c5a8bd4a5d9ddfbf76536d
> src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
>
>
> Diff: https://reviews.apache.org/r/58048/diff/3/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added id to Resource.DiskInfo.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On April 17, 2017, 11:49 a.m., Jie Yu wrote:
> > src/tests/resources_tests.cpp
> > Lines 2255 (patched)
> > <https://reviews.apache.org/r/58048/diff/3/?file=1685272#file1685272line2255>
> >
> > instead of relying on 'count', let's use `size()` instead.
>
> Qian Zhang wrote:
> I think here the intention is to count how many `disks` are in `(r1 + r2)`, so `count()` should be the right method to call.
Yes, exactly. Note that we could use `size` and explicit value checks here, but this would introduce dependencies to the exact disk values which in my opinion makes the code harder to understand.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review172076
-----------------------------------------------------------
On May 19, 2017, 11:16 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 11:16 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154
> include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3
> src/common/resources.cpp 1d07f1a049ba3bb3f5d78f05031f33ba97e07e8c
> src/tests/mesos.hpp 3c57f25ff0bec55582b8a7decef53be61a9ec6f4
> src/tests/resources_tests.cpp 5dcbce2dd4944194b59790551929d6d75b805ba3
> src/v1/resources.cpp 1bb5d0741c9f9ea59f34e92159a335661019444d
>
>
> Diff: https://reviews.apache.org/r/58048/diff/4/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added 'id' and 'metadata' fields to
'Resource.DiskInfo.Source'.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On April 17, 2017, 11:49 a.m., Jie Yu wrote:
> > src/tests/resources_tests.cpp
> > Lines 2255 (patched)
> > <https://reviews.apache.org/r/58048/diff/3/?file=1685272#file1685272line2255>
> >
> > instead of relying on 'count', let's use `size()` instead.
>
> Qian Zhang wrote:
> I think here the intention is to count how many `disks` are in `(r1 + r2)`, so `count()` should be the right method to call.
>
> Benjamin Bannier wrote:
> Yes, exactly. Note that we could use `size` and explicit value checks here, but this would introduce dependencies to the exact disk values which in my opinion makes the code harder to understand.
I removed the code here, but `count` has incorrect semantics (number of users of shared resource instead of number of appearances of a specific `Resource`). I use `size` in newly added code now (an alternative possibility would have been to first filter for a `Resource` and then check the `size` of the result).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review172076
-----------------------------------------------------------
On Sept. 12, 2017, 3:14 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2017, 3:14 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c
> include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5
> src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade
> src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc
> src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb
>
>
> Diff: https://reviews.apache.org/r/58048/diff/5/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added id to Resource.DiskInfo.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review172076
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/resources_tests.cpp
Lines 2255 (patched)
<https://reviews.apache.org/r/58048/#comment245156>
instead of relying on 'count', let's use `size()` instead.
- Jie Yu
On April 5, 2017, 1:56 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated April 5, 2017, 1:56 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
> include/mesos/v1/mesos.proto 228623155c7f68c0f24d173aacbc6eb734f1382f
> src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
> src/tests/mesos.hpp fe897c184829910addec95ace174546092a9e2b2
> src/tests/resources_tests.cpp 343cab2af225a05e32c5a8bd4a5d9ddfbf76536d
> src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
>
>
> Diff: https://reviews.apache.org/r/58048/diff/3/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added id to Resource.DiskInfo.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/
-----------------------------------------------------------
(Updated April 5, 2017, 3:56 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Rewrapped a line, via Jan.
Bugs: MESOS-7312
https://issues.apache.org/jira/browse/MESOS-7312
Repository: mesos
Description
-------
Ids will allow to create distinguishable resources, e.g., of RAW or
BLOCK type.
Diffs (updated)
-----
include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
include/mesos/v1/mesos.proto 228623155c7f68c0f24d173aacbc6eb734f1382f
src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
src/tests/mesos.hpp fe897c184829910addec95ace174546092a9e2b2
src/tests/resources_tests.cpp 343cab2af225a05e32c5a8bd4a5d9ddfbf76536d
src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
Diff: https://reviews.apache.org/r/58048/diff/3/
Changes: https://reviews.apache.org/r/58048/diff/2-3/
Testing
-------
make check (OS X, Fedora25)
Thanks,
Benjamin Bannier
Re: Review Request 58048: Added id to Resource.DiskInfo.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review170832
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/mesos.hpp
Line 1356 (original), 1374 (patched)
<https://reviews.apache.org/r/58048/#comment243705>
Please add a line break after `<` to remove "jaggedness", as it's done, e.g., in `createTaskGroupInfo` above.
- Jan Schlicht
On March 31, 2017, 11:38 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated March 31, 2017, 11:38 a.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
> include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c
> src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
> src/tests/mesos.hpp fe897c184829910addec95ace174546092a9e2b2
> src/tests/resources_tests.cpp 343cab2af225a05e32c5a8bd4a5d9ddfbf76536d
> src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
>
>
> Diff: https://reviews.apache.org/r/58048/diff/2/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>