You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Hayat Behlim via Review Board <no...@reviews.apache.org> on 2022/12/02 06:43:46 UTC
Re: Review Request 74218: RANGER-3983: Support getColumnMasks and getRowFilters in Trino SPI 376+
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74218/#review224936
-----------------------------------------------------------
Ship it!
Ship It!
- Hayat Behlim
On Nov. 29, 2022, 9:12 a.m., ziyue yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74218/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2022, 9:12 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> - https://github.com/trinodb/trino/commit/827de57a50426e804761044d24d96b8877b62b7e
> - https://github.com/trinodb/trino/commit/ac8d2d472201eef7c9a3129bd72835f57f2c3faa
> - https://issues.apache.org/jira/browse/RANGER-3983
>
> The functions `getColumnMask` and `getRowFilter` were deprecated since trino 376, and were removed in 401.
>
> So we should adapt to that change in ranger implementation.
>
>
> Diffs
> -----
>
> plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java cc06187f4
> plugin-trino/src/test/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlTest.java d6c637e5a
> ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java c6b234dc2
>
>
> Diff: https://reviews.apache.org/r/74218/diff/1/
>
>
> Testing
> -------
>
> /opt/maven/3.8.3/bin/mvn clean test
>
> Passed
>
>
> Thanks,
>
> ziyue yang
>
>