You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/14 03:50:30 UTC

[GitHub] [dolphinscheduler] JinyLeeChina opened a new pull request, #12376: [bugfix-10116]fix complement data bug

JinyLeeChina opened a new pull request, #12376:
URL: https://github.com/apache/dolphinscheduler/pull/12376

   closed by #10116 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie merged pull request #12376: [bugfix-10116]fix complement data bug

Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #12376:
URL: https://github.com/apache/dolphinscheduler/pull/12376


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] JinyLeeChina commented on pull request #12376: [bugfix-10116]fix complement data bug

Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on PR #12376:
URL: https://github.com/apache/dolphinscheduler/pull/12376#issuecomment-1314714161

   What scenario has NNP occurred ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] JohnZp commented on pull request #12376: [bugfix-10116]fix complement data bug

Posted by GitBox <gi...@apache.org>.
JohnZp commented on PR #12376:
URL: https://github.com/apache/dolphinscheduler/pull/12376#issuecomment-1314679620

   I find that there is a problem, at least NNP will be generated in the process . I suggest this change:
   ```java
           Map<String, String> result = new HashMap<>();
           switch (commandType) {
               case COMPLEMENT_DATA:
                   if (runTime != null) {
                       businessDate = DateUtils.addDays(runTime, -1);
                       break;
                   } else {
                       return result;
                   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] JohnZp commented on pull request #12376: [bugfix-10116]fix complement data bug

Posted by GitBox <gi...@apache.org>.
JohnZp commented on PR #12376:
URL: https://github.com/apache/dolphinscheduler/pull/12376#issuecomment-1314813268

   > I'm sorry, my description just now is ambiguous. It's an NPE problem.
   
   The problem is that when you define a global parameter like this and then perform the complement operation, the generated processInstance will not have a scheduleTime
   Therefore, calling the following method will occur a null pointer
   
   ![image](https://user-images.githubusercontent.com/25192317/201837725-ffae662d-13db-428d-a076-2ea7a20cf8f3.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] JinyLeeChina commented on pull request #12376: [bugfix-10116]fix complement data bug

Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on PR #12376:
URL: https://github.com/apache/dolphinscheduler/pull/12376#issuecomment-1314943626

   OK, please submit a new issue for this bug


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #12376: [bugfix-10116]fix complement data bug

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #12376:
URL: https://github.com/apache/dolphinscheduler/pull/12376#issuecomment-1278461752

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=12376)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12376&resolved=false&types=BUG) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12376&resolved=false&types=BUG) [62 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12376&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12376&resolved=false&types=VULNERABILITY) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12376&resolved=false&types=VULNERABILITY) [11 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12376&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12376&resolved=false&types=SECURITY_HOTSPOT) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12376&resolved=false&types=SECURITY_HOTSPOT) [11 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12376&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12376&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12376&resolved=false&types=CODE_SMELL) [875 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12376&resolved=false&types=CODE_SMELL)
   
   [![18.1%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '18.1%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12376&metric=new_coverage&view=list) [18.1% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12376&metric=new_coverage&view=list)  
   [![5.3%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/10-16px.png '5.3%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12376&metric=new_duplicated_lines_density&view=list) [5.3% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12376&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org