You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "LemonLiTree (via GitHub)" <gi...@apache.org> on 2023/12/08 07:47:33 UTC
[PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
LemonLiTree opened a new pull request, #28180:
URL: https://github.com/apache/doris/pull/28180
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "LemonLiTree (via GitHub)" <gi...@apache.org>.
LemonLiTree commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1849819135
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1857378098
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1849308764
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 9a619b6b57a6ae5d14d9a0443674ad6aa4a98ec8, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4695 4467 4455 4455
q2 361 154 159 154
q3 1446 1209 1223 1209
q4 1115 897 899 897
q5 3117 3111 3114 3111
q6 248 128 128 128
q7 999 478 484 478
q8 2166 2196 2163 2163
q9 6675 6637 6640 6637
q10 3259 3456 3280 3280
q11 330 205 208 205
q12 346 201 201 201
q13 4599 3856 3816 3816
q14 243 209 214 209
q15 560 519 521 519
q16 442 383 397 383
q17 988 537 562 537
q18 7711 7415 7131 7131
q19 1515 1225 1452 1225
q20 543 298 295 295
q21 3082 2671 2718 2671
q22 351 284 290 284
Total cold run time: 44791 ms
Total hot run time: 39988 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4386 4406 4374 4374
q2 267 171 170 170
q3 3626 3546 3539 3539
q4 2396 2379 2376 2376
q5 5755 5744 5750 5744
q6 240 120 122 120
q7 2377 1904 1844 1844
q8 3507 3507 3521 3507
q9 9087 9036 9021 9021
q10 3878 3972 3971 3971
q11 501 384 380 380
q12 759 595 608 595
q13 4284 3588 3599 3588
q14 288 260 262 260
q15 560 521 520 520
q16 508 455 500 455
q17 1869 1875 1853 1853
q18 8696 8315 8256 8256
q19 1732 1739 1707 1707
q20 2246 1933 1939 1933
q21 6568 6190 6166 6166
q22 508 430 445 430
Total cold run time: 64038 ms
Total hot run time: 60809 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1846865197
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.81 seconds
stream load tsv: 582 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17212360913 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1849978822
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 9a619b6b57a6ae5d14d9a0443674ad6aa4a98ec8, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4644 4413 4451 4413
q2 364 151 158 151
q3 1433 1230 1230 1230
q4 1108 938 840 840
q5 3107 3133 3128 3128
q6 279 129 126 126
q7 972 482 466 466
q8 2183 2209 2174 2174
q9 6652 6673 6620 6620
q10 3202 3229 3241 3229
q11 319 195 193 193
q12 348 207 204 204
q13 4538 3857 5220 3857
q14 243 211 211 211
q15 555 512 537 512
q16 438 382 386 382
q17 1003 515 532 515
q18 9133 7600 7522 7522
q19 1508 1306 1408 1306
q20 1779 323 287 287
q21 3068 2659 2693 2659
q22 348 276 281 276
Total cold run time: 47224 ms
Total hot run time: 40301 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4392 4362 4375 4362
q2 267 161 170 161
q3 3535 3521 3543 3521
q4 2376 2361 2363 2361
q5 5732 5752 5816 5752
q6 238 120 121 120
q7 2376 1883 1907 1883
q8 3498 3525 3515 3515
q9 9019 8948 8995 8948
q10 3901 3971 3963 3963
q11 499 380 386 380
q12 763 597 586 586
q13 4280 3553 3542 3542
q14 291 255 258 255
q15 565 526 520 520
q16 495 438 480 438
q17 1872 1857 1864 1857
q18 8706 8385 8210 8210
q19 1713 1749 1759 1749
q20 2376 1936 1922 1922
q21 6533 6192 6127 6127
q22 514 438 407 407
Total cold run time: 63941 ms
Total hot run time: 60579 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #28180:
URL: https://github.com/apache/doris/pull/28180#discussion_r1420063290
##########
be/src/util/jsonb_document.h:
##########
@@ -1573,6 +1573,7 @@ inline bool JsonbPath::parse_member(Stream* stream, JsonbPath* path) {
stream->skip(1);
stream->add_leg_len();
stream->set_has_escapes(true);
+ if (stream->exhausted()) return false;
Review Comment:
warning: statement should be inside braces [readability-braces-around-statements]
```suggestion
if (stream->exhausted()) { return false;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1857268785
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.49 seconds
stream load tsv: 584 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17219632804 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1849318148
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.79 seconds
stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17220956646 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1856136448
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk merged PR #28180:
URL: https://github.com/apache/doris/pull/28180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1849998456
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.89 seconds
stream load tsv: 579 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17219799840 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1855234545
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1855234485
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "LemonLiTree (via GitHub)" <gi...@apache.org>.
LemonLiTree commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1857185355
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "LemonLiTree (via GitHub)" <gi...@apache.org>.
LemonLiTree commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1846719703
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1847116604
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 9a619b6b57a6ae5d14d9a0443674ad6aa4a98ec8, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4731 4433 4529 4433
q2 366 179 154 154
q3 1448 1308 1279 1279
q4 1098 924 864 864
q5 3106 3115 3137 3115
q6 251 133 128 128
q7 993 476 479 476
q8 2175 2206 2176 2176
q9 6654 6651 6707 6651
q10 3203 3235 3234 3234
q11 330 202 196 196
q12 352 208 206 206
q13 4530 3820 3807 3807
q14 237 213 214 213
q15 556 526 524 524
q16 441 381 393 381
q17 991 583 550 550
q18 7419 7098 6950 6950
q19 1506 1337 1415 1337
q20 526 308 300 300
q21 3053 2606 2680 2606
q22 356 283 286 283
Total cold run time: 44322 ms
Total hot run time: 39863 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4430 4390 4402 4390
q2 266 164 173 164
q3 3533 3522 3518 3518
q4 2377 2360 2358 2358
q5 5730 5701 5725 5701
q6 239 126 123 123
q7 2373 1893 1889 1889
q8 3484 3493 3491 3491
q9 9002 8982 8987 8982
q10 3897 4007 4000 4000
q11 502 390 395 390
q12 773 590 600 590
q13 4305 3540 3595 3540
q14 281 251 255 251
q15 577 515 516 515
q16 502 451 467 451
q17 1880 1862 1845 1845
q18 8667 8090 8336 8090
q19 1716 1717 1722 1717
q20 2250 1943 1932 1932
q21 6492 6158 6154 6154
q22 511 449 425 425
Total cold run time: 63787 ms
Total hot run time: 60516 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "LemonLiTree (via GitHub)" <gi...@apache.org>.
LemonLiTree commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1849246750
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1857313479
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 737d3cbc62c9954f13d6f5f5513cb121d296a0f8, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4725 4499 4481 4481
q2 363 158 158 158
q3 1461 1238 1209 1209
q4 1099 893 885 885
q5 3198 3168 3155 3155
q6 246 130 129 129
q7 960 487 485 485
q8 2189 2240 2187 2187
q9 6693 6714 6648 6648
q10 3201 3271 3269 3269
q11 328 203 196 196
q12 349 208 212 208
q13 4570 3799 3783 3783
q14 239 213 211 211
q15 568 525 518 518
q16 434 384 383 383
q17 1009 657 573 573
q18 7053 6782 6914 6782
q19 1555 1478 1338 1338
q20 502 289 309 289
q21 3047 2605 2663 2605
q22 345 280 279 279
Total cold run time: 44134 ms
Total hot run time: 39771 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4416 4420 4384 4384
q2 266 165 172 165
q3 3509 3495 3497 3495
q4 2380 2362 2375 2362
q5 5737 5738 5749 5738
q6 235 121 123 121
q7 2372 1880 1867 1867
q8 3523 3516 3517 3516
q9 9047 9034 9001 9001
q10 3913 4030 3999 3999
q11 489 374 381 374
q12 767 594 602 594
q13 4301 3541 3590 3541
q14 283 255 247 247
q15 576 528 528 528
q16 502 452 467 452
q17 1870 1857 1858 1857
q18 8572 8133 8215 8133
q19 1754 1752 1764 1752
q20 2250 1972 1928 1928
q21 6481 6137 6158 6137
q22 485 425 421 421
Total cold run time: 63728 ms
Total hot run time: 60612 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bug](json)Fix the problem of be down caused by json path ending with \ [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28180:
URL: https://github.com/apache/doris/pull/28180#issuecomment-1857177613
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org