[GitHub] [beam] lukecwik commented on a change in pull request #15091: [BEAM-12547] Fix vendoring of epoll

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #15091:
URL: https://github.com/apache/beam/pull/15091#discussion_r660811491



##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_36_0.groovy
##########
@@ -49,7 +49,7 @@ class GrpcVendoring_1_36_0 {
       "io.grpc:grpc-netty:$grpc_version",
       "io.grpc:grpc-protobuf:$grpc_version",
       "io.grpc:grpc-stub:$grpc_version",
-      "io.netty:netty-transport-native-epoll:$netty_version",
+      "io.netty:netty-transport-native-epoll:$netty_version:linux-x86_64",

Review comment:
       You need to specify a classifier as the non-classifier only contains classes and no native code. Many other libs typically have a jar that contains all the native files necessary.
   
   Note that I'm explicitly not adding support for aarch64.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org