You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/10/29 14:26:12 UTC
Review Request 63397: Added a map from OfferOperationID to internal
operation UUID.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63397/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Repository: mesos
Description
-------
Added a map from OfferOperationID to internal operation UUID.
Diffs
-----
src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
Diff: https://reviews.apache.org/r/63397/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 63397: Added a map from OfferOperationID to
internal operation UUID.
Posted by Jie Yu <yu...@gmail.com>.
> On Oct. 30, 2017, 11:17 a.m., Benjamin Bannier wrote:
> > src/master/master.hpp
> > Lines 2995 (patched)
> > <https://reviews.apache.org/r/63397/diff/2/?file=1872391#file1872391line2995>
> >
> > I am not sure how this will be used, but it should be important to map from frameworks to offer operation IDs (e.g., for cleanup when a framework is removed for good).
> >
> > We should also soon follow this up with something to prevent this map from growing without bounds, maybe add a `TODO` here, or add minimal cleanup in https://reviews.apache.org/r/63358/.
Currently, no new operation can be used. But yeah, will follow up with patches soon.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63397/#review189563
-----------------------------------------------------------
On Oct. 29, 2017, 3:50 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63397/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2017, 3:50 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a map from OfferOperationID to internal operation UUID.
>
>
> Diffs
> -----
>
> src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
>
>
> Diff: https://reviews.apache.org/r/63397/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 63397: Added a map from OfferOperationID to
internal operation UUID.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63397/#review189563
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.hpp
Lines 2995 (patched)
<https://reviews.apache.org/r/63397/#comment266691>
I am not sure how this will be used, but it should be important to map from frameworks to offer operation IDs (e.g., for cleanup when a framework is removed for good).
We should also soon follow this up with something to prevent this map from growing without bounds, maybe add a `TODO` here, or add minimal cleanup in https://reviews.apache.org/r/63358/.
- Benjamin Bannier
On Oct. 29, 2017, 4:50 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63397/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2017, 4:50 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a map from OfferOperationID to internal operation UUID.
>
>
> Diffs
> -----
>
> src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
>
>
> Diff: https://reviews.apache.org/r/63397/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 63397: Added a map from OfferOperationID to
internal operation UUID.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63397/
-----------------------------------------------------------
(Updated Oct. 29, 2017, 3:50 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Added a map from OfferOperationID to internal operation UUID.
Diffs (updated)
-----
src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
Diff: https://reviews.apache.org/r/63397/diff/2/
Changes: https://reviews.apache.org/r/63397/diff/1-2/
Testing
-------
make check
Thanks,
Jie Yu