[kudu-CR] KUDU-1317. Spread creation of new tablets more randomly

["Binglin Chang (Code Review)" <ge...@ip-10-146-233-104.ec2.internal>]

Binglin Chang has posted comments on this change.

Change subject: KUDU-1317. Spread creation of new tablets more randomly
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1654/8/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

Line 355:     // Decay load estimates on tablet servers.
> hm, how could we make it lazy? we need to look at the vector every time in 
Something like:

def increment_recent_replica_creations():
  if count != 0:
    count *= decay(now - last_update)
  count ++
  last_update = now

def recent_replica_creations():
  if count < 1e-2:
    count = 0
  else:
    count *= decay(now - last_update)
    last_update = now
  return count

This put all related code in just one place,  rather than spread into 2 place.


-- 
To view, visit http://gerrit.cloudera.org:8080/1654
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a27c2ed52b49baeffb309ebecd3d58192eaeec6
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Binglin Chang <de...@gmail.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes