You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Tim Behrendsen (JIRA)" <ji...@apache.org> on 2013/03/27 14:49:15 UTC
[jira] [Updated] (THRIFT-1905) Struct names with underscores get
mangled in PHP compiled output
[ https://issues.apache.org/jira/browse/THRIFT-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Behrendsen updated THRIFT-1905:
-----------------------------------
Description:
When compiling a thrift file containing a struct name with underscores, the underscores get stripped out in the name if the struct is used as a type hint in a function definition.
EXAMPLE THRIFT FILE
------------------------------------------------------------------
{noformat}
namespace php TEST
struct Test_SQL_Row {
1: map<string,string> row
}
service New_Service {
i16 Tester(1:Test_SQL_Row row),
}
{noformat}
------------------------------------------------------------------
SNIPPET FROM COMPILED OUTPUT
Command: thrift -r --gen php bad.thrift
------------------------------------------------------------------
{noformat}
public function Tester(\TEST\TestSQLRow $row)
{
$this->send_Tester($row);
return $this->recv_Tester();
}
{noformat}
------------------------------------------------------------------
was:
When compiling a thrift file containing a struct name with underscores, the underscores get stripped out in the name if the struct is used as a type hint in a function definition.
EXAMPLE THRIFT FILE
------------------------------------------------------------------
namespace php TEST
struct Test_SQL_Row {
1: map<string,string> row
}
service New_Service {
i16 Tester(1:Test_SQL_Row row),
}
------------------------------------------------------------------
SNIPPET FROM COMPILED OUTPUT
Command: thrift -r --gen php bad.thrift
------------------------------------------------------------------
public function Tester(\TEST\TestSQLRow $row)
{
$this->send_Tester($row);
return $this->recv_Tester();
}
------------------------------------------------------------------
> Struct names with underscores get mangled in PHP compiled output
> ----------------------------------------------------------------
>
> Key: THRIFT-1905
> URL: https://issues.apache.org/jira/browse/THRIFT-1905
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Compiler
> Affects Versions: 0.9
> Environment: Centos 6.4
> Reporter: Tim Behrendsen
>
> When compiling a thrift file containing a struct name with underscores, the underscores get stripped out in the name if the struct is used as a type hint in a function definition.
> EXAMPLE THRIFT FILE
> ------------------------------------------------------------------
> {noformat}
> namespace php TEST
> struct Test_SQL_Row {
> 1: map<string,string> row
> }
> service New_Service {
> i16 Tester(1:Test_SQL_Row row),
> }
> {noformat}
> ------------------------------------------------------------------
> SNIPPET FROM COMPILED OUTPUT
> Command: thrift -r --gen php bad.thrift
> ------------------------------------------------------------------
> {noformat}
> public function Tester(\TEST\TestSQLRow $row)
> {
> $this->send_Tester($row);
> return $this->recv_Tester();
> }
> {noformat}
> ------------------------------------------------------------------
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira