You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by ga...@apache.org on 2008/12/11 15:31:55 UTC
svn commit: r725699 - in
/geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin:
geronimo.bat geronimo.sh
Author: gawor
Date: Thu Dec 11 06:31:55 2008
New Revision: 725699
URL: http://svn.apache.org/viewvc?rev=725699&view=rev
Log:
display complete usage info for geronimo stop command (GERONIMO-4463)
Modified:
geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.bat
geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh
Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.bat
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.bat?rev=725699&r1=725698&r2=725699&view=diff
==============================================================================
--- geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.bat (original)
+++ geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.bat Thu Dec 11 06:31:55 2008
@@ -248,7 +248,9 @@
echo args for stop command:
echo --user Admin user
echo --password Admin password
+echo --host Hostname of the server
echo --port RMI port to connect to
+echo --secure Enable secure JMX communication
goto end
:doDebug
Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh?rev=725699&r1=725698&r2=725699&view=diff
==============================================================================
--- geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh (original)
+++ geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh Thu Dec 11 06:31:55 2008
@@ -374,7 +374,9 @@
echo "args for stop command:"
echo " --user Admin user"
echo " --password Admin password"
+ echo " --host Hostname of the server"
echo " --port RMI port to connect to"
+ echo " --secure Enable secure JMX communication"
exit 1
fi
Re: svn commit: r725699 - in /geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin: geronimo.bat geronimo.sh
Posted by Kevan Miller <ke...@gmail.com>.
On Dec 11, 2008, at 12:49 PM, David Jencks wrote:
> I believe apache policy is that patch commit messages need to
> include mention of the contributor. It would probably be a good
> idea to edit the commit messages to include that, e.g. ... Thanks
> to Jack Cai
Pretty sure that Jarek had already fixed that...
--kevan
Re: svn commit: r725699 - in /geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin: geronimo.bat geronimo.sh
Posted by David Jencks <da...@yahoo.com>.
Umm, next time maybe I'll look at all the commits before jumping the
gun.... obviously you already fixed this.
sorry :-(
david jencks
On Dec 11, 2008, at 9:49 AM, David Jencks wrote:
> I believe apache policy is that patch commit messages need to
> include mention of the contributor. It would probably be a good
> idea to edit the commit messages to include that, e.g. ... Thanks
> to Jack Cai
>
> thanks
> david jenkcs
>
> On Dec 11, 2008, at 6:31 AM, gawor@apache.org wrote:
>
>> Author: gawor
>> Date: Thu Dec 11 06:31:55 2008
>> New Revision: 725699
>>
>> URL: http://svn.apache.org/viewvc?rev=725699&view=rev
>> Log:
>> display complete usage info for geronimo stop command (GERONIMO-4463)
>>
>> Modified:
>> geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/
>> underlay/contents/bin/geronimo.bat
>> geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/
>> underlay/contents/bin/geronimo.sh
>>
>> Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate/src/
>> main/underlay/contents/bin/geronimo.bat
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.bat?rev=725699&r1=725698&r2=725699&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/
>> underlay/contents/bin/geronimo.bat (original)
>> +++ geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/
>> underlay/contents/bin/geronimo.bat Thu Dec 11 06:31:55 2008
>> @@ -248,7 +248,9 @@
>> echo args for stop command:
>> echo --user Admin user
>> echo --password Admin password
>> +echo --host Hostname of the server
>> echo --port RMI port to connect to
>> +echo --secure Enable secure JMX communication
>> goto end
>>
>> :doDebug
>>
>> Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate/src/
>> main/underlay/contents/bin/geronimo.sh
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh?rev=725699&r1=725698&r2=725699&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/
>> underlay/contents/bin/geronimo.sh (original)
>> +++ geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/
>> underlay/contents/bin/geronimo.sh Thu Dec 11 06:31:55 2008
>> @@ -374,7 +374,9 @@
>> echo "args for stop command:"
>> echo " --user Admin user"
>> echo " --password Admin password"
>> + echo " --host Hostname of the server"
>> echo " --port RMI port to connect to"
>> + echo " --secure Enable secure JMX communication"
>> exit 1
>>
>> fi
>>
>>
>
Re: svn commit: r725699 - in /geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin: geronimo.bat geronimo.sh
Posted by David Jencks <da...@yahoo.com>.
I believe apache policy is that patch commit messages need to include
mention of the contributor. It would probably be a good idea to edit
the commit messages to include that, e.g. ... Thanks to Jack Cai
thanks
david jenkcs
On Dec 11, 2008, at 6:31 AM, gawor@apache.org wrote:
> Author: gawor
> Date: Thu Dec 11 06:31:55 2008
> New Revision: 725699
>
> URL: http://svn.apache.org/viewvc?rev=725699&view=rev
> Log:
> display complete usage info for geronimo stop command (GERONIMO-4463)
>
> Modified:
> geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/
> underlay/contents/bin/geronimo.bat
> geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/
> underlay/contents/bin/geronimo.sh
>
> Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate/src/
> main/underlay/contents/bin/geronimo.bat
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.bat?rev=725699&r1=725698&r2=725699&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/
> underlay/contents/bin/geronimo.bat (original)
> +++ geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/
> underlay/contents/bin/geronimo.bat Thu Dec 11 06:31:55 2008
> @@ -248,7 +248,9 @@
> echo args for stop command:
> echo --user Admin user
> echo --password Admin password
> +echo --host Hostname of the server
> echo --port RMI port to connect to
> +echo --secure Enable secure JMX communication
> goto end
>
> :doDebug
>
> Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate/src/
> main/underlay/contents/bin/geronimo.sh
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh?rev=725699&r1=725698&r2=725699&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/
> underlay/contents/bin/geronimo.sh (original)
> +++ geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/
> underlay/contents/bin/geronimo.sh Thu Dec 11 06:31:55 2008
> @@ -374,7 +374,9 @@
> echo "args for stop command:"
> echo " --user Admin user"
> echo " --password Admin password"
> + echo " --host Hostname of the server"
> echo " --port RMI port to connect to"
> + echo " --secure Enable secure JMX communication"
> exit 1
>
> fi
>
>