You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Xiang Ji <ji...@cmss.chinamobile.com> on 2018/09/29 07:38:30 UTC

Review Request 68884: Groups show wrong when creating alert notification

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68884/
-----------------------------------------------------------

Review request for Ambari, Andrii Babiichuk, Eugene Chekanskiy, Jonathan Hurley, and Matt.


Bugs: AMBARI-24713
    https://issues.apache.org/jira/browse/AMBARI-24713


Repository: ambari


Description
-------

Create a new alert notification on Alert page, choose one or more items about 'Groups', which shows 'None selected' after saving.


Diffs
-----

  ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js ddb8874a43 


Diff: https://reviews.apache.org/r/68884/diff/1/


Testing
-------

Done


Thanks,

Xiang Ji


Re: Review Request 68884: Groups show wrong when creating alert notification

Posted by Vivek Ratnavel Subramanian <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68884/#review209119
-----------------------------------------------------------



We have moved from review board to Github Pull Requests model to accept contributions. Please follow the guide on "How to contribute to Ambari" to create a pull request - https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute . Thanks!

- Vivek Ratnavel Subramanian


On Sept. 29, 2018, 7:38 a.m., Xiang Ji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68884/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2018, 7:38 a.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Eugene Chekanskiy, Jonathan Hurley, and Matt.
> 
> 
> Bugs: AMBARI-24713
>     https://issues.apache.org/jira/browse/AMBARI-24713
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a new alert notification on Alert page, choose one or more items about 'Groups', which shows 'None selected' after saving.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js ddb8874a43 
> 
> 
> Diff: https://reviews.apache.org/r/68884/diff/1/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> Xiang Ji
> 
>