You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2019/02/15 03:00:00 UTC

[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public

    [ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768899#comment-16768899 ] 

Hudson commented on HBASE-21782:
--------------------------------

Results for branch master
	[build #797 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/797/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/797//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/797//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/797//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> LoadIncrementalHFiles should not be IA.Public
> ---------------------------------------------
>
>                 Key: HBASE-21782
>                 URL: https://issues.apache.org/jira/browse/HBASE-21782
>             Project: HBase
>          Issue Type: Task
>          Components: mapreduce
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 3.0.0, 2.2.0
>
>         Attachments: HBASE-21782-v1.patch, HBASE-21782.patch
>
>
> It is an implementation class, so some of the methods which are only supposed to be used by replication sink are also public to users. And it exposes methods which take Table and Connection as parameter and inside the implementation we assume that they are HTable and ConnectionImplementation, which will be a pain when we want to replace the sync client implementation with async client.
> Here I think we should make the implementation class as IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles programmatically.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)