[GitHub] [beam] liferoad commented on a diff in pull request #26206: wait_until_finish always raises the exception

["liferoad (via GitHub)" <gi...@apache.org>]

liferoad commented on code in PR #26206:
URL: https://github.com/apache/beam/pull/26206#discussion_r1161989708


##########
sdks/python/apache_beam/runners/dataflow/dataflow_runner.py:
##########
@@ -1556,6 +1554,12 @@ def wait_until_finish(self, duration=None):
             'Dataflow pipeline failed. State: %s, Error:\n%s' %
             (self.state, getattr(self._runner, 'last_error_msg', None)),
             self)
+    elif PipelineState.is_terminal(
+        self.state) and self.state != PipelineState.DONE and self._runner:

Review Comment:
   My concern is that this PR breaks the existing behavior. It used to return the state but with this PR, it throws out the exception.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org