You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "chickenlj (GitHub)" <gi...@apache.org> on 2019/01/23 08:52:34 UTC
[GitHub] [incubator-dubbo] chickenlj opened pull request #3317:
[Dubbo-2423] Multicast demo fails with message "Can't assign requested
address".
## What is the purpose of the change
Fixes #2423
## Brief changelog
MulticastRegistry
NetUtils
## Verifying this change
Run demos using the multicast registry.
Check MulticastRegistryTest UT
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [x] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3317 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] chickenlj commented on pull request #3317:
[Dubbo-2423] Multicast demo fails with message "Can't assign requested
address".
Posted by "chickenlj (GitHub)" <gi...@apache.org>.
I think we should also include ipv6 hint in the error message.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3317 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] htynkn commented on pull request #3317:
[Dubbo-2423] Multicast demo fails with message "Can't assign requested
address".
Posted by "htynkn (GitHub)" <gi...@apache.org>.
how about ipv6 address. should we print different error message?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3317 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3317:
[Dubbo-2423] Multicast demo fails with message "Can't assign requested
address".
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3317?src=pr&el=h1) Report
> Merging [#3317](https://codecov.io/gh/apache/incubator-dubbo/pull/3317?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/d27fb1f5aa46706a52f63b336932dc24ab95b82f?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `53.33%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3317 +/- ##
============================================
+ Coverage 63.78% 63.82% +0.03%
Complexity 75 75
============================================
Files 661 661
Lines 28612 28630 +18
Branches 4823 4823
============================================
+ Hits 18251 18272 +21
+ Misses 8153 8143 -10
- Partials 2208 2215 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3317?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3317/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `63.39% <20%> (-3.28%)` | `0 <0> (ø)` | |
| [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3317/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | `57.86% <60%> (+0.34%)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3317/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `37.5% <0%> (-50%)` | `0% <0%> (ø)` | |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3317/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `78.04% <0%> (-7.32%)` | `0% <0%> (ø)` | |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3317/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `57.64% <0%> (-4.71%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3317/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-4.35%)` | `0% <0%> (ø)` | |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3317/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NoYW5uZWxXcmFwcGVkSW52b2tlci5qYXZh) | `45.83% <0%> (-4.17%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3317/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `70.94% <0%> (-4.06%)` | `0% <0%> (ø)` | |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3317/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `56.82% <0%> (+0.36%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3317/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3317?src=pr&el=footer). Last update [d27fb1f...18ce6c5](https://codecov.io/gh/apache/incubator-dubbo/pull/3317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3317 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 closed pull request #3317:
[Dubbo-2423] Multicast demo fails with message "Can't assign requested
address".
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3317 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] htynkn commented on pull request #3317:
[Dubbo-2423] Multicast demo fails with message "Can't assign requested
address".
Posted by "htynkn (GitHub)" <gi...@apache.org>.
why those code are removed? are we still need `-Djava.net.preferIPv4Stack=true` after this change are made?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3317 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] chickenlj commented on pull request #3317:
[Dubbo-2423] Multicast demo fails with message "Can't assign requested
address".
Posted by "chickenlj (GitHub)" <gi...@apache.org>.
No, only because this UT can not pass in travis with ipv6 address. I think the travis host does not have an interface supporting ipv6.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3317 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on issue #3317:
[Dubbo-2423] Multicast demo fails with message "Can't assign requested
address".
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
let's merge it, I will follow up with the error message.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3317 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org