[jira] [Comment Edited] (OAK-3878) Avoid caching of NodeDocument while iterating in BlobReferenceIterator

["Julian Reschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207230#comment-16207230 ] 

Julian Reschke edited comment on OAK-3878 at 10/17/17 9:49 AM:
---------------------------------------------------------------

[~chetanm], [~mreutegg],  []: isn't it actually a bit dangerous to bypass the cache in these cases? What if the non-cached special query returns a document, and the caller subsequently retrieves the document again using the regular (cached) API? In this case, it might end up with an older version than the one previously returned by the query. If this is correct, we probably should invalidate or update cache entries when present...


was (Author: reschke):
[~chetanm], [~mreutegg]: isn't it actually a bit dangerous to bypass the cache in these cases? What if the non-cached special query returns a document, and the caller subsequently retrieves the document again using the regular (cached) API? In this case, it might end up with an older version than the one previously returned by the query. If this is correct, we probably should invalidate or update cache entries when present...

> Avoid caching of NodeDocument while iterating in BlobReferenceIterator
> ----------------------------------------------------------------------
>
>                 Key: OAK-3878
>                 URL: https://issues.apache.org/jira/browse/OAK-3878
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: documentmk
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.8
>
>
> {{BlobReferenceIterator}} in DocumentMK makes use of {{DocumentStore}} API to query the NodeDocument. This would cause all those NodeDocuments to be added to cache in DocumentStore. Due to this when blob gc is running cache usage would not be that effective due to all the associated churn. 
> As these NodeDocument are only required for BlobGC logic and its not expected that this document would read again soon it would be better to skip caching of these documents within DocumentStore
> Similar requirement exist in VersionGC logic but there we use direct store based API which does not add such documents to the cache



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)