You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/19 23:31:12 UTC

[GitHub] [incubator-nuttx] acassis opened a new pull request, #7363: esp32s2: Fix SPI

acassis opened a new pull request, #7363:
URL: https://github.com/apache/incubator-nuttx/pull/7363

   ## Summary
   Fix issues found on ESP32S2 SPI driver
   ## Impact
   User will be able to use SPI on ESP32S2
   ## Testing
   esp32s2-saola-1
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7363: esp32s2: Fix SPI

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7363:
URL: https://github.com/apache/incubator-nuttx/pull/7363


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on a diff in pull request #7363: esp32s2: Fix SPI

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on code in PR #7363:
URL: https://github.com/apache/incubator-nuttx/pull/7363#discussion_r1000079836


##########
arch/xtensa/src/esp32s2/esp32s2_spi.c:
##########
@@ -233,11 +352,18 @@ static struct esp32s2_spi_priv_s esp32s2_spi2_priv =
 {
   .spi_dev     =
     {
-      .ops     = &esp32s2_spi2_ops
+      .ops = &esp32s2_spi2_ops
     },
   .config      = &esp32s2_spi2_config,
   .refs        = 0,
-  .lock        = NXMUTEX_INITIALIZER,
+  .exclsem     = SEM_INITIALIZER(0),

Review Comment:
   @acassis 
   Do you want to revert the change introduced https://github.com/apache/incubator-nuttx/pull/6965?
   I think the changes are not DMA related and perhaps your code base is too old.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org