You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2024/02/28 02:27:42 UTC
[PR] [SPARK-47201][PYTHON][CONNECT] `sameSemantics` checks input types [spark]
zhengruifeng opened a new pull request, #45300:
URL: https://github.com/apache/spark/pull/45300
### What changes were proposed in this pull request?
`sameSemantics` checks input types in the same way as vanilla pyspark
### Why are the changes needed?
for parity
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
updated ut
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47201][PYTHON][CONNECT] `sameSemantics` checks input types [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #45300:
URL: https://github.com/apache/spark/pull/45300#discussion_r1505251493
##########
python/pyspark/sql/tests/test_dataframe.py:
##########
@@ -1843,15 +1843,14 @@ def check_to_local_iterator_not_fully_consumed(self):
self.assertEqual(df.take(8), result)
def test_same_semantics_error(self):
- with QuietTest(self.sc):
Review Comment:
this checking only happens in python side, no need to use `QuietTest` which configs log4j
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47201][PYTHON][CONNECT] `sameSemantics` checks input types [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #45300:
URL: https://github.com/apache/spark/pull/45300#issuecomment-1968079694
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47201][PYTHON][CONNECT] `sameSemantics` checks input types [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #45300: [SPARK-47201][PYTHON][CONNECT] `sameSemantics` checks input types
URL: https://github.com/apache/spark/pull/45300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org