You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2024/10/21 12:30:48 UTC

[PR] fix: Domain 'undefined' error in Storybook [superset]

kgabryje opened a new pull request, #30661:
URL: https://github.com/apache/superset/pull/30661

   
   ### SUMMARY
   Due to incorrect configuration of the default bootstrap data, part of the language pack was undefined, causing every component that uses `t()` (translation function) to crash.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   <img width="1728" alt="image" src="https://github.com/user-attachments/assets/21bd9f32-c5e7-45f3-a940-77fc96dbdd83">
   
   After:
   
   <img width="1727" alt="image" src="https://github.com/user-attachments/assets/c7eef047-8ca4-4502-998c-d08e553cf5f5">
   
   
   ### TESTING INSTRUCTIONS
   1. npm run storybook
   2. Verify that storybook runs normally
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix: Domain 'undefined' error in Storybook [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30661:
URL: https://github.com/apache/superset/pull/30661#issuecomment-2448245379

   THANK YOU! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix: Domain 'undefined' error in Storybook [superset]

Posted by "geido (via GitHub)" <gi...@apache.org>.
geido merged PR #30661:
URL: https://github.com/apache/superset/pull/30661


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org