[GitHub] [ignite] timoninmaxim commented on a change in pull request #9167: IGNITE-13364 Imrove indexes inline defaults

[GitBox <gi...@apache.org>]

timoninmaxim commented on a change in pull request #9167:
URL: https://github.com/apache/ignite/pull/9167#discussion_r687832370



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/cache/query/index/sorted/IndexKeyDefinition.java
##########
@@ -34,11 +34,20 @@
     /** Order. */
     private final Order order;
 
+    /** Precision for variable length key types. */
+    private final long precision;

Review comment:
       @AMashenkov Hi! Thanks for the comment. I use long as h2.Column use this type. Actually precision size doesn't depends on inline size, as H2 limit precision for String and byte[] as Integer.MAX_VALUE. H2 supports blob, and precision for blobs is Long.MAX_VALUE. This is a reason H2 stores precision as long. 
   
   As Ignite doesn't support blobs we can use int instead. So, I'll fix it. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org