You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jake Farrell <jf...@apache.org> on 2014/06/26 05:23:57 UTC

Re: Review Request 19796: AURORA-145:Test dependencies leak into distribution

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19796/
-----------------------------------------------------------

(Updated June 26, 2014, 3:23 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
-------

rebase against master, gradlew clean build passes tests


Bugs: AURORA-145
    https://issues.apache.org/jira/browse/AURORA-145


Repository: aurora


Description
-------

AURORA-145:Test dependencies leak into distribution

Moves testing dependencies out of main src into test.


Diffs (updated)
-----

  build.gradle be2ff053f5bba4248a1ddc2f67b4f055e4e3f841 
  src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java  
  src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java  

Diff: https://reviews.apache.org/r/19796/diff/


Testing
-------

Was initially waiting on AURORA-132 for this. ran build-support/jenkins/build.sh and created dists with no issues.


Thanks,

Jake Farrell

Re: Review Request 19796: AURORA-145:Test dependencies leak into distribution

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19796/#review46789
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On June 26, 2014, 3:23 a.m., Jake Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19796/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 3:23 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-145
>     https://issues.apache.org/jira/browse/AURORA-145
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-145:Test dependencies leak into distribution
> 
> Moves testing dependencies out of main src into test.
> 
> 
> Diffs
> -----
> 
>   build.gradle be2ff053f5bba4248a1ddc2f67b4f055e4e3f841 
>   src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java  
>   src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java  
> 
> Diff: https://reviews.apache.org/r/19796/diff/
> 
> 
> Testing
> -------
> 
> Was initially waiting on AURORA-132 for this. ran build-support/jenkins/build.sh and created dists with no issues.
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>