You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/09 01:27:40 UTC

[GitHub] [tvm] gromero commented on a change in pull request #8941: [microTVM] Zephyr: implement 'west_cmd' server option

gromero commented on a change in pull request #8941:
URL: https://github.com/apache/tvm/pull/8941#discussion_r704882645



##########
File path: apps/microtvm/zephyr/template_project/microtvm_api_server.py
##########
@@ -451,6 +451,11 @@ def flash(self, options):
             recover_args.extend(_get_nrf_device_args(options))
             check_call(recover_args, cwd=API_SERVER_DIR / "build")
 
+        if "west_cmd" in options:
+            west_cmd = options["west_cmd"]
+            cmake_args = ["cmake", "..", f"-DWEST={west_cmd}"]

Review comment:
       @areusch Yeah, I was following what we had previously to Project API. Makes sense. Done in https://github.com/apache/tvm/pull/8941/commits/395bcbe88399adcd0134711ad6da56d6a42297ea
   
   Thanks for the review!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org