You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2021/03/09 15:39:05 UTC
[Impala-ASF-CR] IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17164
Change subject: IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified
......................................................................
IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified
ImpalaJdbcClient might silently choose the HiveDriver when the
connection string is not specified. It's because the default
connection string is 'jdbc:hive2://...'.
This patch adds a check to ImpalaJdbcClient to make sure the driver
being used is the one specified by the user. If not, it raises an
error.
I also modified bin/run-jdbc-client.sh to make it easier to use
different drivers. Users are now able to specify the classpath
of their custom driver via the environment variable
IMPALA_JDBC_DRIVER_CLASSPATH.
Testing:
* tested manually
Change-Id: If7fdf49b7f04f4d9ae6286df5c8df6b205cbce8f
---
M bin/run-jdbc-client.sh
M fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java
2 files changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/17164/1
--
To view, visit http://gerrit.cloudera.org:8080/17164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If7fdf49b7f04f4d9ae6286df5c8df6b205cbce8f
Gerrit-Change-Number: 17164
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17164 )
Change subject: IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7fdf49b7f04f4d9ae6286df5c8df6b205cbce8f
Gerrit-Change-Number: 17164
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Mar 2021 23:03:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17164 )
Change subject: IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6943/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7fdf49b7f04f4d9ae6286df5c8df6b205cbce8f
Gerrit-Change-Number: 17164
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Mar 2021 17:29:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17164 )
Change subject: IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7fdf49b7f04f4d9ae6286df5c8df6b205cbce8f
Gerrit-Change-Number: 17164
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Mar 2021 17:25:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17164 )
Change subject: IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8316/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7fdf49b7f04f4d9ae6286df5c8df6b205cbce8f
Gerrit-Change-Number: 17164
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Mar 2021 15:59:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17164 )
Change subject: IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified
......................................................................
IMPALA-10571: ImpalaJdbcClient might silently choose a different driver than the one specified
ImpalaJdbcClient might silently choose the HiveDriver when the
connection string is not specified. It's because the default
connection string is 'jdbc:hive2://...'.
This patch adds a check to ImpalaJdbcClient to make sure the driver
being used is the one specified by the user. If not, it raises an
error.
I also modified bin/run-jdbc-client.sh to make it easier to use
different drivers. Users are now able to specify the classpath
of their custom driver via the environment variable
IMPALA_JDBC_DRIVER_CLASSPATH.
Testing:
* tested manually
Change-Id: If7fdf49b7f04f4d9ae6286df5c8df6b205cbce8f
Reviewed-on: http://gerrit.cloudera.org:8080/17164
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/run-jdbc-client.sh
M fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java
2 files changed, 15 insertions(+), 2 deletions(-)
Approvals:
Thomas Tauber-Marshall: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If7fdf49b7f04f4d9ae6286df5c8df6b205cbce8f
Gerrit-Change-Number: 17164
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>