[jira] [Commented] (FELIX-3971) [DS] SingleDynamicCustomizer doesn't respond correctly to configuration update events.

["David Jencks (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605671#comment-13605671 ] 

David Jencks commented on FELIX-3971:
-------------------------------------

The main issue is fixed with tests for everything except factory components in revs 1457985-1457988.

I made the dependencyManager customizer final and just replace the tracker since it's too hard to move state between an old and new customizer.

I don't understand what should happen with factory component updates and asked on the dev list.
                
> [DS] SingleDynamicCustomizer doesn't respond correctly to configuration update events.
> --------------------------------------------------------------------------------------
>
>                 Key: FELIX-3971
>                 URL: https://issues.apache.org/jira/browse/FELIX-3971
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR)
>    Affects Versions: scr-1.8.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: scr-1.8.0
>
>
> SingleDynamicCustomizer.addedService only processes events if they were not in the previous satisfied set for the old config.  But the config may have changed which service satisfies the filter.  We need different logic here.
>             if ( getPreviousRefMap().remove( serviceReference ) == null )
> works for multipleDynamicCustomizer, but not the single one.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira