You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2026/01/07 11:06:25 UTC
[PR] [v3-1-test] Fix log task instance join (#59973) [airflow]
github-actions[bot] opened a new pull request, #60208:
URL: https://github.com/apache/airflow/pull/60208
* Fix incorrect Log and TaskInstance join query
* Fix log task instance join foreign keys and remove stray newsfragment
* Remove unused task variable assignments in test_log_task_instance_join_correctness
* Fix CI failures and address reviewer comments: revert unrelated doc changes, clean up tests, add Mapped type hints to Log relationships, and run ruff formatting
* Restore newsfragment and fix missing import in log.py
* Fix reviewer feedback: add license, move imports, and fix newsfragments
* Fix ruff static check failure in log.py
* Flatten primaryjoin definition to fix formatting
* Fix newsfragments per review: restore 58337 and remove 59965
* Remove unused import in log.py
---------
(cherry picked from commit 91af86ecbef39304fc3fc6018da9ff1ba1853bee)
Co-authored-by: Subham <su...@gmail.com>
Co-authored-by: Jason(Zhe-You) Liu <68...@users.noreply.github.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [v3-1-test] Fix log task instance join (#59973) [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #60208: [v3-1-test] Fix log task instance join (#59973)
URL: https://github.com/apache/airflow/pull/60208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [v3-1-test] Fix log task instance join (#59973) [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #60208:
URL: https://github.com/apache/airflow/pull/60208#issuecomment-3718957424
@Subham-KRLX - this backport introduces errors on v3-1-test - maybe you can fix those if we are to backport the fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [v3-1-test] Fix log task instance join (#59973) [airflow]
Posted by "Subham-KRLX (via GitHub)" <gi...@apache.org>.
Subham-KRLX commented on PR #60208:
URL: https://github.com/apache/airflow/pull/60208#issuecomment-3719484448
I have created a manual backport to fix the CI issues in `v3-1-test`.
The errors were caused by SQLAlchemy 2.0 `Mapped` type hints which are not compatible with the `v3-1-test` environment.
I have opened a new PR with the fix (removing type hints while keeping the logic correction): #60222
Closing this one in favor of the manual backport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [v3-1-test] Fix log task instance join (#59973) [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #60208:
URL: https://github.com/apache/airflow/pull/60208#discussion_r2668529428
##########
airflow-core/src/airflow/models/log.py:
##########
@@ -49,18 +50,18 @@ class Log(Base):
extra = Column(Text)
try_number = Column(Integer)
- dag_model = relationship(
+ dag_model: Mapped[DagModel | None] = relationship(
"DagModel",
viewonly=True,
foreign_keys=[dag_id],
primaryjoin="Log.dag_id == DagModel.dag_id",
)
- task_instance = relationship(
+ task_instance: Mapped[TaskInstance | None] = relationship(
Review Comment:
Yes, must be these sqlalchemy2.0 annotation type that CI is not happy about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org