[GitHub] merlimat closed pull request #1724: Exclude grpc dependencies in binary distribution

[GitBox <gi...@apache.org>]

merlimat closed pull request #1724: Exclude grpc dependencies in binary distribution
URL: https://github.com/apache/incubator-pulsar/pull/1724
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/all/src/assemble/bin.xml b/all/src/assemble/bin.xml
index e74b68405b..3c58be7425 100644
--- a/all/src/assemble/bin.xml
+++ b/all/src/assemble/bin.xml
@@ -111,6 +111,9 @@
         <!-- Already included in pulsar-zookeeper instrumented jar -->
         <exclude>org.apache.zookeeper:zookeeper</exclude>
 
+        <!-- Already shaded in runtime-shaded jar -->
+        <exclude>io.grpc:*</exclude>
+
         <!-- Explicitely remove JUnit which is getting pulled in even
              though it's set to the scope 'test' -->
         <exclude>junit:junit</exclude>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services