You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rc...@apache.org on 2020/02/13 02:29:29 UTC

[james-project] 18/21: [REFACTORING] Remove final variable in FetchCommandParser

This is an automated email from the ASF dual-hosted git repository.

rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 06038c87e569b3634c6ae6da833548c816856115
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Tue Jan 14 09:49:39 2020 +0700

    [REFACTORING] Remove final variable in FetchCommandParser
---
 .../james/imap/decode/parser/FetchCommandParser.java     | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/FetchCommandParser.java b/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/FetchCommandParser.java
index 864ffa3..caf93cc 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/FetchCommandParser.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/FetchCommandParser.java
@@ -128,8 +128,8 @@ public class FetchCommandParser extends AbstractUidCommandParser {
 
             reader.consumeChar(']');
 
-            final Long firstOctet;
-            final Long numberOfOctets;
+            Long firstOctet;
+            Long numberOfOctets;
             if (reader.nextChar() == '<') {
                 reader.consumeChar('<');
                 firstOctet = reader.number();
@@ -145,8 +145,8 @@ public class FetchCommandParser extends AbstractUidCommandParser {
                 numberOfOctets = null;
             }
 
-            final BodyFetchElement bodyFetchElement = createBodyElement(parameter, firstOctet, numberOfOctets);
-            final boolean isPeek = isPeek(name);
+            BodyFetchElement bodyFetchElement = createBodyElement(parameter, firstOctet, numberOfOctets);
+            boolean isPeek = isPeek(name);
             fetch.add(bodyFetchElement, isPeek);
         }
     }
@@ -199,13 +199,13 @@ public class FetchCommandParser extends AbstractUidCommandParser {
     }
 
     private BodyFetchElement createBodyElement(String parameter, Long firstOctet, Long numberOfOctets) throws DecodingException {
-        final String responseName = "BODY[" + parameter + "]";
+        String responseName = "BODY[" + parameter + "]";
         FetchPartPathDecoder decoder = new FetchPartPathDecoder();
         decoder.decode(parameter);
-        final SectionType sectionType = decoder.getSpecifier();
+        SectionType sectionType = decoder.getSpecifier();
 
-        final List<String> names = decoder.getNames();
-        final int[] path = decoder.getPath();
+        List<String> names = decoder.getNames();
+        int[] path = decoder.getPath();
         return new BodyFetchElement(responseName, sectionType, path, names, firstOctet, numberOfOctets);
     }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org