Re: [PR] HDDS-12458. Refactor DataNodeSafeModeRule to use NodeManager [ozone]

["aryangupta1998 (via GitHub)" <gi...@apache.org>]

aryangupta1998 commented on PR #7998:
URL: https://github.com/apache/ozone/pull/7998#issuecomment-2778803601

   Thanks for the patch @peterxcli, can we modify the process() of DataNodeSafeModeRule something as,
   ```
   protected void process(NodeRegistrationContainerReport reportsProto) {
   
       if (validateBasedOnReportProcessing()) {
         registeredDnSet.add(reportsProto.getDatanodeDetails().getUuid());
         registeredDns = registeredDnSet.size();
       } else {
         registeredDns = nodeManager.getNodes(NodeStatus.inServiceHealthy()).size();
       }
   
       if (scmInSafeMode()) {
         SCMSafeModeManager.getLogger().info(
             "SCM in safe mode. {} DataNodes registered, {} required.",
             registeredDns, requiredDns);
       }
     }
   ```
   because in future we maynot be needing the datanode reports to process the information!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org