You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ha...@apache.org on 2026/10/13 02:13:07 UTC
(skywalking-banyandb) branch main updated: chore(deps): bump the pending mcp npm deps and fix the false CI version-drift report (#1395)
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
The following commit(s) were added to refs/heads/main by this push:
new 0e1c728ee chore(deps): bump the pending mcp npm deps and fix the false CI version-drift report (#1395)
0e1c728ee is described below
commit 0e1c728ee7311f1d4b8f27231b65d23d233f333f
Author: Gao Hongtao <ha...@gmail.com>
AuthorDate: Tue Oct 13 10:13:02 2026 +0800
chore(deps): bump the pending mcp npm deps and fix the false CI version-drift report (#1395)
---
.github/workflows/test-build-system.yml | 27 +++++++++++++++++++++------
CHANGES.md | 2 ++
mcp/LICENSE | 6 +++---
mcp/package-lock.json | 28 ++++++++++++++++------------
mcp/package.json | 2 +-
5 files changed, 43 insertions(+), 22 deletions(-)
diff --git a/.github/workflows/test-build-system.yml b/.github/workflows/test-build-system.yml
index 975020586..282a4dbe3 100644
--- a/.github/workflows/test-build-system.yml
+++ b/.github/workflows/test-build-system.yml
@@ -167,8 +167,12 @@ jobs:
run: |
set -e
make print-build-args
- if grep -vE '^[[:space:]]*#' scripts/build/dockerize.mk \
- | grep -qE 'linux/amd64|bookworm|[0-9]{2}\.[0-9]+\.[0-9]+'; then
+ # No pipelines here either. Under `bash -eo pipefail` an early-exiting
+ # reader (`grep -q`) SIGPIPEs its writer and the pipeline reports 141,
+ # which here would silently *skip* the check instead of reporting a
+ # false positive.
+ non_comment=$(grep -vE '^[[:space:]]*#' scripts/build/dockerize.mk)
+ if grep -qE 'linux/amd64|bookworm|[0-9]{2}\.[0-9]+\.[0-9]+' <<<"$non_comment"; then
echo "::error::a version literal crept into dockerize.mk"
exit 1
fi
@@ -182,7 +186,7 @@ jobs:
run: |
set -e
requested=$(make -n docker-image PLATFORM=linux/arm64 2>/dev/null \
- | grep -oE '\-\-platform [a-z0-9/]+' | head -1 | awk '{print $2}')
+ | grep -oE '\-\-platform [a-z0-9/]+' | awk 'NR == 1 { print $2 }')
echo " requested arm64, got: $requested"
if [ "$requested" != "linux/amd64" ]; then
echo "::error::PLATFORM is overridable; the image would be mislabelled"
@@ -223,9 +227,20 @@ jobs:
want_go=$(sed -n 's/^go //p' go.mod)
want_node=$(bash scripts/ci/check/node_version.sh resolve .)
want_eyes=$(sed -n 's/^LICENSE_EYE_VERSION := //p' scripts/build/version.mk)
- echo "$out" | grep -q "GO_VERSION=$want_go" || { echo "::error::Go version drift"; exit 1; }
- echo "$out" | grep -q "NODE_VERSION=$want_node" || { echo "::error::Node version drift"; exit 1; }
- echo "$out" | grep -q "LICENSE_EYE_VERSION=$want_eyes" || { echo "::error::license-eye drift"; exit 1; }
+ # `grep -q` reads one line at a time and exits on the first match, so the
+ # writer on the other end of the pipe takes SIGPIPE. This step runs under
+ # GitHub's default `bash -eo pipefail`, which turns that 141 into a
+ # pipeline failure -- so a version that *does* match was reported as
+ # "version drift", non-deterministically, on whichever line happened to
+ # race (PR #1386 failed here on a matching NODE_VERSION). Redirect from a
+ # here-string instead: no pipeline, no writer to signal.
+ assert_declared() { # assert_declared <label> <expected>
+ grep -q "^$2\$" <<<"$out" \
+ || { echo "::error::$1 version drift: want '$2', image printed:"; printf '%s\n' "$out" | tail -20; exit 1; }
+ }
+ assert_declared Go "GO_VERSION=$want_go"
+ assert_declared Node "NODE_VERSION=$want_node"
+ assert_declared license-eye "LICENSE_EYE_VERSION=$want_eyes"
echo " ok the image carries the versions the repository declares"
- name: The tree is still clean
diff --git a/CHANGES.md b/CHANGES.md
index ca87dd34c..ac8267cb0 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -77,6 +77,8 @@ Release Notes.
- Bump google.golang.org/grpc to v1.83.2 to clear GO-2026-6443, GO-2026-6441, and GO-2026-6348.
- Bump canopy and mcp npm dependencies to clear Dependabot CVEs (fast-uri, fastify, qs).
- Bump mcp/canopy npm deps (hono, js-yaml, vitest 5) to clear Dependabot CVEs.
+- Bump the pending mcp npm dependencies (`fast-uri` 4.2.1, `ip-address` 10.7.3, `proxy-addr` 2.0.8, and the `brace-expansion` 5.0.12 dev dependency) and regenerate the committed `mcp/LICENSE`, so `make check-req` passes on the Dependabot PRs that only edit `package-lock.json`.
+- Stop `test-build-system.yml` reporting a version drift when the image carries the pinned version: `grep -q` inside a pipeline exited on its first match, SIGPIPEd the writer, and GitHub's default `bash -eo pipefail` turned that into a pipeline failure. The same pipeline shape hid a real regression in the "no version literal" check, where a false 141 skipped the check. Both now read from a here-string, and the platform probe no longer ends in `head -1`.
## 0.11.1
diff --git a/mcp/LICENSE b/mcp/LICENSE
index e5260d2c0..4bc76508a 100644
--- a/mcp/LICENSE
+++ b/mcp/LICENSE
@@ -35,7 +35,7 @@ BSD-2-Clause licenses
BSD-3-Clause licenses
========================================================================
- fast-uri 4.1.4 BSD-3-Clause
+ fast-uri 4.2.1 BSD-3-Clause
qs 6.16.0 BSD-3-Clause
========================================================================
@@ -97,7 +97,7 @@ MIT licenses
hono 4.13.7 MIT
http-errors 2.0.1 MIT
iconv-lite 0.7.3 MIT
- ip-address 10.7.0 MIT
+ ip-address 10.7.3 MIT
ipaddr.js 1.9.1 MIT
is-promise 4.0.0 MIT
jose 6.2.12 MIT
@@ -117,7 +117,7 @@ MIT licenses
path-key 3.1.1 MIT
path-to-regexp 8.4.2 MIT
pkce-challenge 5.0.1 MIT
- proxy-addr 2.0.7 MIT
+ proxy-addr 2.0.8 MIT
range-parser 1.3.0 MIT
raw-body 3.0.2 MIT
require-from-string 2.0.2 MIT
diff --git a/mcp/package-lock.json b/mcp/package-lock.json
index db67b0c61..057271540 100644
--- a/mcp/package-lock.json
+++ b/mcp/package-lock.json
@@ -1589,9 +1589,9 @@
}
},
"node_modules/brace-expansion": {
- "version": "5.0.9",
- "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-5.0.9.tgz",
- "integrity": "sha512-ScQ4IuvIEF1TMlP7Zt+vjJ//9zlPb2SDcxWxM3bk8s6t6GGdJ7KO1dCcTidOPJKePW30LE/2cT7wCyPho9/Wxg==",
+ "version": "5.0.12",
+ "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-5.0.12.tgz",
+ "integrity": "sha512-YovQ3rzhaLMIrDjNDMkNS01tea93qhEhG5xy8f6+R0l+dw3Ki+5sCoIoI942iuLZTHWogWktgwVDhU09iNEimQ==",
"dev": true,
"license": "MIT",
"dependencies": {
@@ -2254,9 +2254,9 @@
"license": "MIT"
},
"node_modules/fast-uri": {
- "version": "4.1.4",
- "resolved": "https://registry.npmjs.org/fast-uri/-/fast-uri-4.1.4.tgz",
- "integrity": "sha512-dODXrIxlS9JSdgAnhIUKOosKV1oMtU2VtVw87QRaHzyl5jxO290Ii5tEZfCfzfWNHi3jKWwBSdQj0qIyshdZdQ==",
+ "version": "4.2.1",
+ "resolved": "https://registry.npmjs.org/fast-uri/-/fast-uri-4.2.1.tgz",
+ "integrity": "sha512-TmHQgewjHtMq1E5QKA0tOE0yeYGQs25KZC/ziJpubRtWI15W92e6vPFydWOeZBVROSHBYw/QhD9d5OefdD6LDg==",
"funding": [
{
"type": "github",
@@ -2582,9 +2582,9 @@
"license": "ISC"
},
"node_modules/ip-address": {
- "version": "10.7.0",
- "resolved": "https://registry.npmjs.org/ip-address/-/ip-address-10.7.0.tgz",
- "integrity": "sha512-BGFsyJd5mpXp3rK6jIdADLNgpJUK1jnjzvYF8lK+VyDab9JAmqN0YOKDdP17HlgKb2+ehPgDc8EtnRLbGCAMhA==",
+ "version": "10.7.3",
+ "resolved": "https://registry.npmjs.org/ip-address/-/ip-address-10.7.3.tgz",
+ "integrity": "sha512-A1kdq/tSb5QjvKvAMgIoEvDBIgL7qaqVP/jkvSwYYRZ9iEzvPpopxp2wQfu3SuZRHtpHNxMn8Fs0bS+gf5Xmwg==",
"license": "MIT",
"engines": {
"node": ">= 12"
@@ -3090,9 +3090,9 @@
}
},
"node_modules/proxy-addr": {
- "version": "2.0.7",
- "resolved": "https://registry.npmjs.org/proxy-addr/-/proxy-addr-2.0.7.tgz",
- "integrity": "sha512-llQsMLSUDUPT44jdrU/O37qlnifitDP+ZwrmmZcoSKyLKvtZxpyV0n2/bD/N4tBAAZ/gJEdZU7KMraoK1+XYAg==",
+ "version": "2.0.8",
+ "resolved": "https://registry.npmjs.org/proxy-addr/-/proxy-addr-2.0.8.tgz",
+ "integrity": "sha512-5nnx0yGyVUcY6t9RnWcARWtwT9F1D8O9rt08htPvnd49W1IgZtmLkhu9WfMzQj1cFxjHIO6connUNVW5k7AVyQ==",
"license": "MIT",
"dependencies": {
"forwarded": "0.2.0",
@@ -3100,6 +3100,10 @@
},
"engines": {
"node": ">= 0.10"
+ },
+ "funding": {
+ "type": "opencollective",
+ "url": "https://opencollective.com/express"
}
},
"node_modules/punycode": {
diff --git a/mcp/package.json b/mcp/package.json
index 916589f42..d3ae408a8 100644
--- a/mcp/package.json
+++ b/mcp/package.json
@@ -50,7 +50,7 @@
},
"overrides": {
"@hono/node-server": "^2.1.0",
- "fast-uri": "^4.1.4",
+ "fast-uri": "^4.2.1",
"hono": "^4.13.7",
"qs": "^6.16.0"
}