[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #7009: Fix issues around Database permissions

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #7009: Fix issues around Database permissions
URL: https://github.com/apache/incubator-superset/pull/7009#discussion_r273802251
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -285,6 +294,7 @@ class DatabaseView(SupersetModelView, DeleteMixin, YamlExportMixin):  # noqa
         'allow_multi_schema_metadata_fetch': _('Allow Multi Schema Metadata Fetch'),
         'backend': _('Backend'),
     }
+    base_filters = [['id', DatabaseFilter, lambda: []]]
 
 Review comment:
   Do you mean "can't see" (you wrote "can see").  This may require adding `all_database_access` to `alpha`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org