You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/11/17 09:59:22 UTC

[GitHub] [kafka] dongjinleekr commented on pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

dongjinleekr commented on pull request #11431:
URL: https://github.com/apache/kafka/pull/11431#issuecomment-971418712


   @mimaison Here is the fix.
   
   I added `ReplicationPolicyTest` to validate the implementation. It seems like we need to test the other methods but, let's focus on `DefaultReplicationPolicy#isInternalTopic` only in this PR. (I will open a separate PR for it later.)
   
   @OmniaGM Thanks for suggesting the right alternative. :bow:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org