You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hawq.apache.org by linwen <gi...@git.apache.org> on 2016/02/14 07:59:00 UTC

[GitHub] incubator-hawq pull request: HAWQ-240. Set Progress as 50% When Re...

GitHub user linwen opened a pull request:

    https://github.com/apache/incubator-hawq/pull/340

    HAWQ-240. Set Progress as 50% When Return Resource

    Please review. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/linwen/incubator-hawq hawq-240

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #340
    
----
commit 0fe7462a66bd526a8d850409531f242ab94e7e6d
Author: Wen Lin <wl...@pivotal.io>
Date:   2016-02-14T06:55:58Z

    HAWQ-240. Set Progress as 50% When Return Resource

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-240. Set Progress as 50% When Re...

Posted by huor <gi...@git.apache.org>.

Github user huor commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/340#discussion_r52854091
  
    --- Diff: depends/libyarn/src/libyarnclient/LibYarnClient.cpp ---
    @@ -649,7 +649,7 @@ int LibYarnClient::releaseResources(string &jobId,int64_t releaseContainerIds[],
             //3) blacklistRequestBlank
             ResourceBlacklistRequest blacklistRequestBlank;
             //4) progress
    --- End diff --
    
    LGTM. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-240. Set Progress as 50% When Re...

Posted by linwen <gi...@git.apache.org>.

Github user linwen closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/340


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-240. Set Progress as 50% When Re...

Posted by jiny2 <gi...@git.apache.org>.

Github user jiny2 commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/340#issuecomment-184024599
  
    +1 LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---