[GitHub] [beam] mosche commented on issue #20894: Conversion from Avro GenericRecords to Beam Rows takes too much time

["mosche (via GitHub)" <gi...@apache.org>]

mosche commented on issue #20894:
URL: https://github.com/apache/beam/issues/20894#issuecomment-1669225358

   Wondering, have you done some more benchmarks @gabrywu ?
   
   There's been some improvements in the area, particularly improving performance of [RowWithGetters](https://github.com/apache/beam/pull/17172) which is the foundation for most schema providers. The [reverse direction](https://github.com/apache/beam/pull/27534) is still pending, I'll merge after the next release cut.
   
   Though, actually, having a quick look at the code, this unfortunately doesn't apply to `GenericRecord`s. `GenericRecordToRowFn` eagerly converts records to rows rather than just wrapping them and delegating field access the way it is done by `RowWithGetters`. That's absolutely worth improving!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org