You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2024/04/02 15:46:02 UTC

Re: [PR] [TVMScript] Do not throw error for duplicate definitions [tvm]

Lunderberg commented on PR #16811:
URL: https://github.com/apache/tvm/pull/16811#issuecomment-2032420886

   I went back and forth on it, as the existing `ICHECK` could have been changed to a `LOG(WARNING)`.  However, that would prevent it from generating clean error messages for cases that are known to be ill-formed.  (e.g. Highlighting the ill-formed output, as it done for the TIR well-formed checker and which I want to bring over to the Relax well-formed checker.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org