[GitHub] [incubator-livy] lmccay commented on a diff in pull request #348: [LIVY-891] Expose the sessionID via the client APIs [WIP]

[GitBox <gi...@apache.org>]

lmccay commented on code in PR #348:
URL: https://github.com/apache/incubator-livy/pull/348#discussion_r1064172756


##########
rsc/src/main/java/org/apache/livy/rsc/RSCClient.java:
##########
@@ -426,10 +429,15 @@ private void handle(ChannelHandlerContext ctx, ReplState msg) {
       LOG.trace("Received repl state for {}", msg.state);
       // Update last activity timestamp when state change is from busy to idle.
       if (SessionState.Busy$.MODULE$.state().equals(replState) && msg != null &&
-        SessionState.Idle$.MODULE$.state().equals(msg.state)) {
+              SessionState.Idle$.MODULE$.state().equals(msg.state)) {
         replLastActivity = System.nanoTime();
       }
       replState = msg.state;
     }
   }
+  @Override
+  public String getSessionAppId(){throw new UnsupportedOperationException();}

Review Comment:
   It seems to me that this is pointing to the fact that it is an inappropriate extension to the interface.
   If there are only 2 implementations of the interface and 1 of them throws exceptions for this methods then I don't think they are appropriate for the interface. What is the story here? Session ID isn't known within RSCClient usage?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org