You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/09 15:22:03 UTC

[GitHub] [tvm] cconvey commented on a diff in pull request #11245: [build][hexagon] fix several compiler warnings

cconvey commented on code in PR #11245:
URL: https://github.com/apache/tvm/pull/11245#discussion_r868136516


##########
cmake/modules/Hexagon.cmake:
##########
@@ -172,6 +172,14 @@ if(USE_HEXAGON_RPC)
           -o "${TVMRT_SOURCE_DIR}/hexagon/rpc"
       MAIN_DEPENDENCY "${TVMRT_SOURCE_DIR}/hexagon/rpc/hexagon_rpc.idl"
     )
+
+    if (("${CMAKE_C_COMPILER_ID}" STREQUAL "GNU") OR ("${CMAKE_C_COMPILER_ID}" STREQUAL "Clang"))
+        # We can't easily fix this at the source-code level, because the .c file is generated
+        # by the qaic program.  But it should be save to ignore the warning:

Review Comment:
   Typo: save --> safe



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org