You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/12/12 08:21:15 UTC
Review Request 28986: Removed Resources::extract in favor of
reservation-based helpers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28986/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
We no longer need 'extract', now that we have the more explicit reservation-based helpers.
Diffs
-----
include/mesos/resources.hpp 10777a62492e4a3333d764e0f75c064694e054d1
src/common/resources.cpp 535a0eab6377b9ae63c960cdb05978647f667d5e
src/master/hierarchical_allocator_process.hpp 610fcd97b76f8581cb3253237ab0948420b6949a
src/tests/hierarchical_allocator_tests.cpp 7e3dcd5ae27dcf4f0358fe62d51916cb7d522c09
Diff: https://reviews.apache.org/r/28986/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 28986: Removed Resources::extract in favor of
reservation-based helpers.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28986/#review64939
-----------------------------------------------------------
Ship it!
Thanks for the clean ups!
- Jie Yu
On Dec. 12, 2014, 7:21 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28986/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2014, 7:21 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> We no longer need 'extract', now that we have the more explicit reservation-based helpers.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 10777a62492e4a3333d764e0f75c064694e054d1
> src/common/resources.cpp 535a0eab6377b9ae63c960cdb05978647f667d5e
> src/master/hierarchical_allocator_process.hpp 610fcd97b76f8581cb3253237ab0948420b6949a
> src/tests/hierarchical_allocator_tests.cpp 7e3dcd5ae27dcf4f0358fe62d51916cb7d522c09
>
> Diff: https://reviews.apache.org/r/28986/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>