You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2004/12/22 16:40:03 UTC
[jira] Created: (JCR-35) NodeTypeDefDiff compares to restrictive
NodeTypeDefDiff compares to restrictive
---------------------------------------
Key: JCR-35
URL: http://nagoya.apache.org/jira/browse/JCR-35
Project: Jackrabbit
Type: Bug
Environment: Jackrabbit SVN Rev. 122969
Reporter: Felix Meschberger
The NodeTypeDefDiff class is used to compare NodeTypeDef instances. Unfortunately this class reports two NodeTypeDef instances which are not equal but have no structural difference as having trivial changes. The correct result would be to have no modification at all.
I suggest to modify the NodeTypeDefDiff.init() method such, that the initial type is "NONE" instead of "TRIVIAL" and to first compare the "hasOrderableChildNodes" first and raise the level to "TRIVIAL" if not equal. Next the rest of the current comparisons would follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Assigned: (JCR-35) NodeTypeDefDiff compares to restrictive
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-35?page=history ]
Stefan Guggisberg reassigned JCR-35:
------------------------------------
Assign To: Stefan Guggisberg
> NodeTypeDefDiff compares to restrictive
> ---------------------------------------
>
> Key: JCR-35
> URL: http://issues.apache.org/jira/browse/JCR-35
> Project: Jackrabbit
> Type: Bug
> Environment: Jackrabbit SVN Rev. 122969
> Reporter: Felix Meschberger
> Assignee: Stefan Guggisberg
>
> The NodeTypeDefDiff class is used to compare NodeTypeDef instances. Unfortunately this class reports two NodeTypeDef instances which are not equal but have no structural difference as having trivial changes. The correct result would be to have no modification at all.
> I suggest to modify the NodeTypeDefDiff.init() method such, that the initial type is "NONE" instead of "TRIVIAL" and to first compare the "hasOrderableChildNodes" first and raise the level to "TRIVIAL" if not equal. Next the rest of the current comparisons would follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Closed: (JCR-35) NodeTypeDefDiff compares to restrictive
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-35?page=history ]
Stefan Guggisberg closed JCR-35:
--------------------------------
> NodeTypeDefDiff compares to restrictive
> ---------------------------------------
>
> Key: JCR-35
> URL: http://issues.apache.org/jira/browse/JCR-35
> Project: Jackrabbit
> Type: Bug
> Environment: Jackrabbit SVN Rev. 122969
> Reporter: Felix Meschberger
> Assignee: Stefan Guggisberg
>
> The NodeTypeDefDiff class is used to compare NodeTypeDef instances. Unfortunately this class reports two NodeTypeDef instances which are not equal but have no structural difference as having trivial changes. The correct result would be to have no modification at all.
> I suggest to modify the NodeTypeDefDiff.init() method such, that the initial type is "NONE" instead of "TRIVIAL" and to first compare the "hasOrderableChildNodes" first and raise the level to "TRIVIAL" if not equal. Next the rest of the current comparisons would follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Resolved: (JCR-35) NodeTypeDefDiff compares to restrictive
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-35?page=history ]
Stefan Guggisberg resolved JCR-35:
----------------------------------
Resolution: Fixed
fixed in rev. 123964:
added NodeTypeDef#equals(Object)
> NodeTypeDefDiff compares to restrictive
> ---------------------------------------
>
> Key: JCR-35
> URL: http://issues.apache.org/jira/browse/JCR-35
> Project: Jackrabbit
> Type: Bug
> Environment: Jackrabbit SVN Rev. 122969
> Reporter: Felix Meschberger
> Assignee: Stefan Guggisberg
>
> The NodeTypeDefDiff class is used to compare NodeTypeDef instances. Unfortunately this class reports two NodeTypeDef instances which are not equal but have no structural difference as having trivial changes. The correct result would be to have no modification at all.
> I suggest to modify the NodeTypeDefDiff.init() method such, that the initial type is "NONE" instead of "TRIVIAL" and to first compare the "hasOrderableChildNodes" first and raise the level to "TRIVIAL" if not equal. Next the rest of the current comparisons would follow.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira