You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@poi.apache.org by bu...@apache.org on 2008/01/09 10:40:18 UTC

DO NOT REPLY [Bug 35928] - [PATCH] POIFS hardcodes big-block size to 512

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=35928>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35928


nick@torchbox.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO




------- Additional Comments From nick@torchbox.com  2008-01-09 01:40 -------
The patch doesn't look to be threadsafe to me

If we had two files open, one with a 512 blocksize, and another with a 4096
blocksize, then I think it'd fail, as it's all using a single static int on
POIFSFileSystem

I think before we could apply this, we would need a sample file with the
alternate block size (so we can write a unit test for all this), and the patch
would need to be slightly re-worked to be threadsafe (i.e. not use a static for
something that can vary between concurrantly open files).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org