[GitHub] [mynewt-nimble] ncasaril commented on a change in pull request #944: nimble/ll_conn: Fix for frag tx of mbufs >255 bytes

[GitBox <gi...@apache.org>]

ncasaril commented on a change in pull request #944:
URL: https://github.com/apache/mynewt-nimble/pull/944#discussion_r662044231



##########
File path: nimble/controller/src/ble_ll_conn.c
##########
@@ -1129,11 +1129,10 @@ ble_ll_conn_tx_pdu(struct ble_ll_conn_sm *connsm)
         if ((cur_offset + cur_txlen) < pktlen) {
             next_txlen = pktlen - (cur_offset + cur_txlen);
         } else {
-            if (nextpkthdr->omp_len > connsm->eff_max_tx_octets) {
-                next_txlen = connsm->eff_max_tx_octets;
-            } else {
-                next_txlen = nextpkthdr->omp_len;
-            }
+            next_txlen = connsm->eff_max_tx_octets;

Review comment:
       This should instead probably be
    
   ```
        next_txlen = nextpkthdr->omp_len;
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org