You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Trustin Lee (JIRA)" <ji...@apache.org> on 2005/02/05 16:45:25 UTC

[jira] Created: (DIRMINA-7) FilterManagers are not thread-safe.

FilterManagers are not thread-safe.
-----------------------------------

         Key: DIRMINA-7
         URL: http://issues.apache.org/jira/browse/DIRMINA-7
     Project: MINA
        Type: Bug
    Versions: 0.7    
    Reporter: Trustin Lee
 Assigned to: Trustin Lee 
     Fix For: 0.7


FilterManagers will malfunction if events are fired while any filter is added or removed simultaneously.  We'll have to fix this issue by using ReadWriteLock.  Is it OK for us to use Doug Lea's concurrent package here?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Re: [jira] Created: (DIRMINA-7) FilterManagers are not thread-safe.

Posted by Trustin Lee <tr...@gmail.com>.
Hi,

On Sat, 05 Feb 2005 18:29:01 -0500, Alex Karasulu <ao...@bellsouth.net> wrote:
> Trustin Lee (JIRA) wrote:
> 
> >FilterManagers are not thread-safe.
> >-----------------------------------
> >
> >         Key: DIRMINA-7
> >         URL: http://issues.apache.org/jira/browse/DIRMINA-7
> >     Project: MINA
> >        Type: Bug
> >    Versions: 0.7
> >    Reporter: Trustin Lee
> > Assigned to: Trustin Lee
> >     Fix For: 0.7
> >
> >
> >FilterManagers will malfunction if events are fired while any filter is added or removed simultaneously.  We'll have to fix this issue by using ReadWriteLock.  Is it OK for us to use Doug Lea's concurrent package here?
> >
> >
> Yeah we're fine doing that from a software license compatability
> standpoint - go right ahead.
> 
> Alex
> 

Thanks for the fast response.  I consulted legal-discuss@apache.org
and I'm condifent I'm definitely OK to use it. :)

Cheers,
Trustin
-- 
what we call human nature is actually human habit
--
http://gleamynode.net/

Re: [jira] Created: (DIRMINA-7) FilterManagers are not thread-safe.

Posted by Alex Karasulu <ao...@bellsouth.net>.
Trustin Lee (JIRA) wrote:

>FilterManagers are not thread-safe.
>-----------------------------------
>
>         Key: DIRMINA-7
>         URL: http://issues.apache.org/jira/browse/DIRMINA-7
>     Project: MINA
>        Type: Bug
>    Versions: 0.7    
>    Reporter: Trustin Lee
> Assigned to: Trustin Lee 
>     Fix For: 0.7
>
>
>FilterManagers will malfunction if events are fired while any filter is added or removed simultaneously.  We'll have to fix this issue by using ReadWriteLock.  Is it OK for us to use Doug Lea's concurrent package here?
>  
>
Yeah we're fine doing that from a software license compatability 
standpoint - go right ahead.

Alex

[jira] Closed: (DIRMINA-7) FilterManagers are not thread-safe.

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-7?page=history ]
     
Trustin Lee closed DIRMINA-7:
-----------------------------

    Resolution: Fixed

http://svn.apache.org/viewcvs?view=rev&rev=151670

I replaced complex Double-linked list with array to store the chain of filters.  Instead the range of filter priorities are limited.  You will find IoHandlerFilter.MIN/MAX_PRIORITY and ProtocolHandlerFilter.MIN/MAX_PRIORITY constants.  Because FilterManagers has been changed to store filter entries to an array whose index is priority value, the filter chain traversal is not very efficient.  But the range of the filter priority is 100 which is fairly small, so I think it is OK at most situation.

> FilterManagers are not thread-safe.
> -----------------------------------
>
>          Key: DIRMINA-7
>          URL: http://issues.apache.org/jira/browse/DIRMINA-7
>      Project: MINA
>         Type: Bug
>     Versions: 0.7
>     Reporter: Trustin Lee
>     Assignee: Trustin Lee
>      Fix For: 0.7

>
> FilterManagers will malfunction if events are fired while any filter is added or removed simultaneously.  We'll have to fix this issue by using ReadWriteLock.  Is it OK for us to use Doug Lea's concurrent package here?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira