You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/10 06:11:26 UTC
[GitHub] [incubator-superset] etr2460 opened a new pull request #10282: chore: add typing to profile
etr2460 opened a new pull request #10282:
URL: https://github.com/apache/incubator-superset/pull/10282
### SUMMARY
As titled. There was also some unused state in some components, so I cleaned it up
### TEST PLAN
CI, unit tests, manual confirmation of all the tabs on the profile
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
to: @graceguo-supercat @ktmud @suddjian @kristw
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #10282: chore: add typing to profile
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #10282:
URL: https://github.com/apache/incubator-superset/pull/10282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10282: chore: add typing to profile
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10282:
URL: https://github.com/apache/incubator-superset/pull/10282#discussion_r454705896
##########
File path: superset-frontend/package.json
##########
@@ -208,7 +211,7 @@
"@types/react": "^16.9.38",
"@types/react-dom": "^16.9.8",
"@types/react-json-tree": "^0.6.11",
- "@types/react-redux": "^7.1.7",
+ "@types/react-redux": "^5.0.2",
Review comment:
we're using `react-redux` 5.0.2, not 7.1.7, so i figure we should use the proper types here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #10282: chore: add typing to profile
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #10282:
URL: https://github.com/apache/incubator-superset/pull/10282#issuecomment-657891835
ping @graceguo-supercat @ktmud or @suddjian for review, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10282: chore: add typing to profile
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10282:
URL: https://github.com/apache/incubator-superset/pull/10282#discussion_r454672053
##########
File path: superset-frontend/package.json
##########
@@ -208,7 +211,7 @@
"@types/react": "^16.9.38",
"@types/react-dom": "^16.9.8",
"@types/react-json-tree": "^0.6.11",
- "@types/react-redux": "^7.1.7",
+ "@types/react-redux": "^5.0.2",
Review comment:
Why the downgrade?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org