You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/02/05 05:11:54 UTC
[GitHub] [knox] lmccay opened a new pull request #255: KNOX-2224 - KnoxLine
and KnoxShell DataSource and Select Command Alignment
lmccay opened a new pull request #255: KNOX-2224 - KnoxLine and KnoxShell DataSource and Select Command Alignment
URL: https://github.com/apache/knox/pull/255
(It is very **important** that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!)
## What changes were proposed in this pull request?
The KnoxLine shell environment datasource selection creates the connection for the session. The connection is kept for the session or until datasource select is used to create a connection to a new datasource. Each SQL query continues to use the same connection. The connections are cleaned up and closed through a shutdown hook for the KnoxLine environment.
In the interactive KnoxShell there are Custom Groovy Commands for datasource management and SQL queries submission. The life of the connection is limited to each command rather than being able to be used again in subsequent queries. Connections are closed for each query. This requires a new connection and login per query - since login isn't done at datasource selection time like it is in KnoxLine.
This change aligns the two environments. Connections are managed at the shell environment level rather than at the command level. Connections are created when selecting datasources rather than and SQL query invocation. Connections are cleaned up in the interactive shell through a shutdown hook.
## How was this patch tested?
Manually tested and unit tests run for project.
Please review [Knox Contributing Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow) before opening a pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] lmccay merged pull request #255: KNOX-2224 - KnoxLine and
KnoxShell DataSource and Select Command Alignment
Posted by GitBox <gi...@apache.org>.
lmccay merged pull request #255: KNOX-2224 - KnoxLine and KnoxShell DataSource and Select Command Alignment
URL: https://github.com/apache/knox/pull/255
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services