[GitHub] [kafka] cadonna commented on a diff in pull request #13017: KAFKA-14530: Check state updater more often

[GitBox <gi...@apache.org>]

cadonna commented on code in PR #13017:
URL: https://github.com/apache/kafka/pull/13017#discussion_r1053559527


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -880,9 +885,7 @@ void runOnce() {
     private void initializeAndRestorePhase() {
         final java.util.function.Consumer<Set<TopicPartition>> offsetResetter = partitions -> resetOffsets(partitions, null);
         final State stateSnapshot = state;
-        if (stateUpdaterEnabled) {
-            checkStateUpdater();
-        } else {
+        if (!stateUpdaterEnabled) {

Review Comment:
   Shall we move this `if` to where `initializeAndRestorePhase()` is called? Then we would have both checks about whether the state updater is enabled in the same method not far from each other. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org