You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/14 05:32:45 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #32547: [SPARK-35351][SQL] Add code-gen for left anti sort merge join
cloud-fan commented on a change in pull request #32547:
URL: https://github.com/apache/spark/pull/32547#discussion_r632296238
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
##########
@@ -693,15 +701,12 @@ case class SortMergeJoinExec(
| continue;
| }
|}
- |if (!$loaded) {
- | $loaded = true;
- | $streamedAfter
Review comment:
For left anti, `streamedAfter` will appear twice in the code. How large is it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org