You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/01/14 08:39:01 UTC
[GitHub] [zookeeper] lanicc opened a new pull request #1579: ZOOKEEPER-4058: Update checkstyle-strict.xml by the latest version 8.39 of checkstyle
lanicc opened a new pull request #1579:
URL: https://github.com/apache/zookeeper/pull/1579
See [https://checkstyle.sourceforge.io/config_javadoc.html](https://checkstyle.sourceforge.io/config_javadoc.html)
- JavadocMethod: remove properties allowMissingJavadoc,allowMissingThrowsTags,allowThrowsTagsForSubclasses,allowUndeclaredRTE
- LineLength: change it's parent to Checker
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ctubbsii edited a comment on pull request #1579: ZOOKEEPER-4058: Update checkstyle-strict.xml by the latest version 8.39 of checkstyle
Posted by GitBox <gi...@apache.org>.
ctubbsii edited a comment on pull request #1579:
URL: https://github.com/apache/zookeeper/pull/1579#issuecomment-760616958
CI builds are failing for this PR, because of new checkstyle errors that occur as a result of this change. They should be resolved in order to accept this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] lanicc commented on pull request #1579: ZOOKEEPER-4058: Update checkstyle-strict.xml by the latest version 8.39 of checkstyle
Posted by GitBox <gi...@apache.org>.
lanicc commented on pull request #1579:
URL: https://github.com/apache/zookeeper/pull/1579#issuecomment-760751296
> CI builds are failing for this PR, because of new checkstyle errors that occur as a result of this change. They should be resolved in order to accept this PR.
yes, I'm trying to fix this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] lanicc closed pull request #1579: ZOOKEEPER-4058: Update checkstyle-strict.xml by the latest version 8.39 of checkstyle
Posted by GitBox <gi...@apache.org>.
lanicc closed pull request #1579:
URL: https://github.com/apache/zookeeper/pull/1579
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] lanicc commented on pull request #1579: ZOOKEEPER-4058: Update checkstyle-strict.xml by the latest version 8.39 of checkstyle
Posted by GitBox <gi...@apache.org>.
lanicc commented on pull request #1579:
URL: https://github.com/apache/zookeeper/pull/1579#issuecomment-760920130
These problems (CI building error) seem to have nothing to do with the revision
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1579: ZOOKEEPER-4058: Update checkstyle to the latest version 8.39
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1579:
URL: https://github.com/apache/zookeeper/pull/1579#issuecomment-761874067
Thank you, @lanicc! Merged into `master`, `branch-3.7` and `branch-3.7.0`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg closed pull request #1579: ZOOKEEPER-4058: Update checkstyle to the latest version 8.39
Posted by GitBox <gi...@apache.org>.
ztzg closed pull request #1579:
URL: https://github.com/apache/zookeeper/pull/1579
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ctubbsii commented on pull request #1579: ZOOKEEPER-4058: Update checkstyle-strict.xml by the latest version 8.39 of checkstyle
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1579:
URL: https://github.com/apache/zookeeper/pull/1579#issuecomment-760616958
CI builds are failing, because of new checkstyle errors after this change. They should be resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] lanicc closed pull request #1579: ZOOKEEPER-4058: Update checkstyle-strict.xml by the latest version 8.39 of checkstyle
Posted by GitBox <gi...@apache.org>.
lanicc closed pull request #1579:
URL: https://github.com/apache/zookeeper/pull/1579
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org