You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:18:03 UTC

[GitHub] [iceberg] nastra commented on a change in pull request #2703: Add more null checks to TableIdentifier

nastra commented on a change in pull request #2703:
URL: https://github.com/apache/iceberg/pull/2703#discussion_r654164645



##########
File path: api/src/main/java/org/apache/iceberg/catalog/TableIdentifier.java
##########
@@ -36,6 +36,7 @@
   private final String name;
 
   public static TableIdentifier of(String... names) {
+    Preconditions.checkArgument(names != null, "Cannot create table identifier from null array");

Review comment:
       there's also a test that verifies this behavior: https://github.com/apache/iceberg/pull/2703/files#diff-7d459f8dfa23098a11664c5f2399f8a8a6c27d72bfcf4384e9bb580fdaff0963R72




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org