You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Claudio Martella (Created) (JIRA)" <ji...@apache.org> on 2011/10/21 14:44:32 UTC
[jira] [Created] (GIRAPH-60) Export BspService public get*Path()
methods through static
Export BspService public get*Path() methods through static
----------------------------------------------------------
Key: GIRAPH-60
URL: https://issues.apache.org/jira/browse/GIRAPH-60
Project: Giraph
Issue Type: Improvement
Components: graph
Affects Versions: 0.70.0
Reporter: Claudio Martella
Assignee: Claudio Martella
Priority: Trivial
Fix For: 0.70.0
BspService has methods to compose Paths such as getSuperstepPath() etc. that could be used by other non-implementing classes. We should export them through static.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-60) Export BspService public get*Path()
methods through static
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132928#comment-13132928 ]
Avery Ching commented on GIRAPH-60:
-----------------------------------
=)
> Export BspService public get*Path() methods through static
> ----------------------------------------------------------
>
> Key: GIRAPH-60
> URL: https://issues.apache.org/jira/browse/GIRAPH-60
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Priority: Trivial
> Fix For: 0.70.0
>
>
> BspService has methods to compose Paths such as getSuperstepPath() etc. that could be used by other non-implementing classes. We should export them through static.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-60) Export BspService public get*Path()
methods through static
Posted by "Claudio Martella (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132861#comment-13132861 ]
Claudio Martella commented on GIRAPH-60:
----------------------------------------
As I'm implementing AggregatorsWriter, I realized I'd need to access getMergedAggregatorPath() to get the aggregated values to dump to disk. I wanted to avoid passing BspService to the implementation to hide it from the user.
At second thought, as I can see that it's not so trivial (APPLICATION_ATTEMPTS_PATH is not a constant), I thought to make AggregatorsWriter an abstract class where we would have a setBspService() called by us at instantiation (a bit like what happens now with GraphState somewhere else) and a final JsonObject getMergedValues() method that would return directly the aggregated values to the user. This would allow us to hide BspService and all the machine under the hood and provide the user the merged values ready to write. I'll work on this idea. What do you think?
> Export BspService public get*Path() methods through static
> ----------------------------------------------------------
>
> Key: GIRAPH-60
> URL: https://issues.apache.org/jira/browse/GIRAPH-60
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Priority: Trivial
> Fix For: 0.70.0
>
>
> BspService has methods to compose Paths such as getSuperstepPath() etc. that could be used by other non-implementing classes. We should export them through static.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-60) Export BspService public get*Path()
methods through static
Posted by "Claudio Martella (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132920#comment-13132920 ]
Claudio Martella commented on GIRAPH-60:
----------------------------------------
looking again at your interface I understand I made a mess :) writeAggregators() already gets the aggregated values, so it doesn't really need to access BspService. Sorry :)
> Export BspService public get*Path() methods through static
> ----------------------------------------------------------
>
> Key: GIRAPH-60
> URL: https://issues.apache.org/jira/browse/GIRAPH-60
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Priority: Trivial
> Fix For: 0.70.0
>
>
> BspService has methods to compose Paths such as getSuperstepPath() etc. that could be used by other non-implementing classes. We should export them through static.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-60) Export BspService public get*Path()
methods through static
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132840#comment-13132840 ]
Avery Ching commented on GIRAPH-60:
-----------------------------------
They aren't static because we didn't have a use for them outside of the Bsp class hierarchy. What is the use you have in mind?
> Export BspService public get*Path() methods through static
> ----------------------------------------------------------
>
> Key: GIRAPH-60
> URL: https://issues.apache.org/jira/browse/GIRAPH-60
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Priority: Trivial
> Fix For: 0.70.0
>
>
> BspService has methods to compose Paths such as getSuperstepPath() etc. that could be used by other non-implementing classes. We should export them through static.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (GIRAPH-60) Export BspService public get*Path()
methods through static
Posted by "Claudio Martella (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claudio Martella resolved GIRAPH-60.
------------------------------------
Resolution: Not A Problem
the access to the methods is actually not necessary outside of BspService as first thought.
> Export BspService public get*Path() methods through static
> ----------------------------------------------------------
>
> Key: GIRAPH-60
> URL: https://issues.apache.org/jira/browse/GIRAPH-60
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Claudio Martella
> Assignee: Claudio Martella
> Priority: Trivial
> Fix For: 0.70.0
>
>
> BspService has methods to compose Paths such as getSuperstepPath() etc. that could be used by other non-implementing classes. We should export them through static.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira